Sign upLogin

tensorflow/models

View on GitHub
Star
research/deep_speech/data/download.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function convert_audio_and_split_transcript has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def convert_audio_and_split_transcript(input_dir, source_name, target_name,
                                       output_dir, output_file):
  """Convert FLAC to WAV and split the transcript.

  For audio file, convert the format from FLAC to WAV using the sox.Transformer
Severity: Minor
Found in research/deep_speech/data/download.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          if not tf.io.gfile.exists(wav_file):
            tfm.build(flac_file, wav_file)
          wav_filesize = os.path.getsize(wav_file)
Severity: Major
Found in research/deep_speech/data/download.py - About 45 mins to fix

    Function convert_audio_and_split_transcript has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def convert_audio_and_split_transcript(input_dir, source_name, target_name,
    Severity: Minor
    Found in research/deep_speech/data/download.py - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      if __name__ == "__main__":
  logging.set_verbosity(logging.INFO)
  define_data_download_flags()
  FLAGS = absl_flags.FLAGS
  absl_app.run(main)
      Severity: Major
      Found in research/deep_speech/data/download.py and 1 other location - About 1 hr to fix
      research/deep_speech/deep_speech.py on lines 412..416

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

        if not tf.io.gfile.exists(FLAGS.data_dir):
    tf.io.gfile.makedirs(FLAGS.data_dir)
      Severity: Major
      Found in research/deep_speech/data/download.py and 6 other locations - About 45 mins to fix
      official/legacy/xlnet/preprocess_squad_data.py on lines 101..102
      research/attention_ocr/python/eval.py on lines 48..49
      research/deeplab/datasets/remove_gt_colormap.py on lines 68..69
      research/delf/delf/python/delg/extract_features.py on lines 99..100
      research/delf/delf/python/delg/perform_retrieval.py on lines 183..184
      research/delf/delf/python/detect_to_retrieve/perform_retrieval.py on lines 186..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status