Sign upLogin

tensorflow/models

View on GitHub
Star
research/deeplab/core/conv2d_ws.py

Summary

Maintainability
D
1 day
Test Coverage

File conv2d_ws.py has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Lint as: python2, python3
# Copyright 2019 The TensorFlow Authors All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Severity: Minor
Found in research/deeplab/core/conv2d_ws.py - About 3 hrs to fix

    Function conv2d has 20 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def conv2d(inputs,
    Severity: Major
    Found in research/deeplab/core/conv2d_ws.py - About 2 hrs to fix

      Function __init__ has 19 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def __init__(self,
      Severity: Major
      Found in research/deeplab/core/conv2d_ws.py - About 2 hrs to fix

        Function call has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def call(self, inputs):
    if self.use_weight_standardization:
      mean, var = tf.nn.moments(self.kernel, [0, 1, 2], keep_dims=True)
      kernel = (self.kernel - mean) / tf.sqrt(var + 1e-5)
      outputs = self._convolution_op(inputs, kernel)
        Severity: Minor
        Found in research/deeplab/core/conv2d_ws.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function conv2d has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def conv2d(inputs,
           num_outputs,
           kernel_size,
           stride=1,
           padding='SAME',
        Severity: Minor
        Found in research/deeplab/core/conv2d_ws.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function conv2d_same has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def conv2d_same(inputs, num_outputs, kernel_size, stride, rate=1, scope=None):
        Severity: Minor
        Found in research/deeplab/core/conv2d_ws.py - About 45 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              super(Conv2D, self).__init__(
          Severity: Major
          Found in research/deeplab/core/conv2d_ws.py and 2 other locations - About 2 hrs to fix
          research/lstm_object_detection/meta_architectures/lstm_ssd_meta_arch.py on lines 59..59
          research/lstm_object_detection/model_builder.py on lines 173..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status