Sign upLogin

tensorflow/models

View on GitHub
Star
research/lstm_object_detection/lstm/rnn_decoder.py

Summary

Maintainability
C
1 day
Test Coverage

Function multi_input_rnn_decoder has 11 arguments (exceeds 4 allowed). Consider refactoring.
Open

def multi_input_rnn_decoder(decoder_inputs,
Severity: Major
Found in research/lstm_object_detection/lstm/rnn_decoder.py - About 1 hr to fix

    Function multi_input_rnn_decoder has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def multi_input_rnn_decoder(decoder_inputs,
                            initial_state,
                            cell,
                            sequence_step,
                            selection_strategy='RANDOM',
    Severity: Minor
    Found in research/lstm_object_detection/lstm/rnn_decoder.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generate_action has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def generate_action(selection_strategy, local_step, sequence_step,
                    action_shape):
  """Generate current (binary) action based on selection strategy.

  Args:
    Severity: Minor
    Found in research/lstm_object_detection/lstm/rnn_decoder.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function select_inputs has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def select_inputs(decoder_inputs, action, local_step, is_training, is_quantized,
    Severity: Minor
    Found in research/lstm_object_detection/lstm/rnn_decoder.py - About 45 mins to fix

      Function rnn_decoder has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def rnn_decoder(decoder_inputs,
      Severity: Minor
      Found in research/lstm_object_detection/lstm/rnn_decoder.py - About 35 mins to fix

        Function rnn_decoder has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def rnn_decoder(decoder_inputs,
                initial_state,
                cell,
                loop_function=None,
                scope=None):
        Severity: Minor
        Found in research/lstm_object_detection/lstm/rnn_decoder.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          state_h = previous_state[1] * action + new_state[1] * (1 - action)
        Severity: Major
        Found in research/lstm_object_detection/lstm/rnn_decoder.py and 1 other location - About 1 hr to fix
        research/lstm_object_detection/lstm/rnn_decoder.py on lines 267..267

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          state_c = previous_state[0] * action + new_state[0] * (1 - action)
        Severity: Major
        Found in research/lstm_object_detection/lstm/rnn_decoder.py and 1 other location - About 1 hr to fix
        research/lstm_object_detection/lstm/rnn_decoder.py on lines 268..268

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status