Sign upLogin

tensorflow/models

View on GitHub
Star
research/object_detection/meta_architectures/context_rcnn_meta_arch.py

Summary

Maintainability
F
3 days
Test Coverage

File context_rcnn_meta_arch.py has 560 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2020 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py - About 1 day to fix

    Function __init__ has 49 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def __init__(self,
    Severity: Major
    Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py - About 6 hrs to fix

      Function __init__ has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def __init__(self,
               is_training,
               num_classes,
               image_resizer_fn,
               feature_extractor,
      Severity: Minor
      Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _predict_second_stage has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def _predict_second_stage(self, rpn_box_encodings,
      Severity: Major
      Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py - About 50 mins to fix

        Function _box_prediction has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def _box_prediction(self, rpn_features_to_crop, proposal_boxes_normalized,
        Severity: Minor
        Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py - About 45 mins to fix

          Function _compute_second_stage_input_feature_maps has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def _compute_second_stage_input_feature_maps(self, features_to_crop,
          Severity: Minor
          Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py - About 45 mins to fix

            Function _extract_box_classifier_features has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def _extract_box_classifier_features(
            Severity: Minor
            Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py - About 35 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  if self._mask_rcnn_box_predictor.is_keras_model:
      box_predictions = self._mask_rcnn_box_predictor(
          [box_classifier_features],
          prediction_stage=2)
    else:
              Severity: Major
              Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py and 3 other locations - About 2 hrs to fix
              research/object_detection/meta_architectures/faster_rcnn_meta_arch.py on lines 1070..1078
              research/object_detection/meta_architectures/faster_rcnn_meta_arch.py on lines 1212..1220
              research/object_detection/meta_architectures/faster_rcnn_meta_arch.py on lines 1246..1254

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if self._attention_position == (
        faster_rcnn_pb2.AttentionPosition.POST_RPN):
      attention_features = self._context_feature_extract_fn(
          box_features=flattened_box_features,
          num_proposals=num_proposals,
              Severity: Major
              Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py and 1 other location - About 2 hrs to fix
              research/object_detection/meta_architectures/context_rcnn_meta_arch.py on lines 612..621

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if self._attention_position == (
        faster_rcnn_pb2.AttentionPosition.POST_BOX_CLASSIFIER):
      attention_features = self._context_feature_extract_fn(
          box_features=box_classifier_features,
          num_proposals=num_proposals,
              Severity: Major
              Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py and 1 other location - About 2 hrs to fix
              research/object_detection/meta_architectures/context_rcnn_meta_arch.py on lines 577..586

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  prediction_dict = {
        'refined_box_encodings': tf.cast(refined_box_encodings,
                                         dtype=tf.float32),
        'class_predictions_with_background':
        tf.cast(class_predictions_with_background, dtype=tf.float32),
              Severity: Major
              Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py and 1 other location - About 1 hr to fix
              research/object_detection/meta_architectures/faster_rcnn_meta_arch.py on lines 1091..1099

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if self._feature_extractor_for_box_classifier_features:
      box_classifier_features = (
          self._feature_extractor_for_box_classifier_features(
              flattened_box_features))
    else:
              Severity: Minor
              Found in research/object_detection/meta_architectures/context_rcnn_meta_arch.py and 1 other location - About 55 mins to fix
              research/object_detection/meta_architectures/faster_rcnn_meta_arch.py on lines 1154..1162

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status