File spatial_transform_ops.py
has 467 lines of code (exceeds 250 allowed). Consider refactoring. Open
# Copyright 2019 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Function multilevel_roi_align
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
def multilevel_roi_align(features, boxes, box_levels, output_size,
Function multilevel_matmul_crop_and_resize
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def multilevel_matmul_crop_and_resize(images, boxes, box_levels, crop_size,
Function ravel_indices
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def ravel_indices(feature_grid_y, feature_grid_x, num_levels, height, width,
Function multilevel_native_crop_and_resize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def multilevel_native_crop_and_resize(images, boxes, box_levels,
Function matmul_crop_and_resize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def matmul_crop_and_resize(image, boxes, crop_size, extrapolation_value=0.0,
Similar blocks of code found in 2 locations. Consider refactoring. Open
features_per_box = tf.reshape(
features_per_box,
[batch_size * num_boxes, size_y * 2, size_x * 2, num_filters])
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 35.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76