Sign upLogin

tensorflow/models

View on GitHub
Star
research/slim/nets/cyclegan.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function cyclegan_generator_resnet has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

def cyclegan_generator_resnet(images,
Severity: Major
Found in research/slim/nets/cyclegan.py - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

              with tf.variable_scope('block_{}'.format(block_id)):
            res_net = tf.pad(tensor=net, paddings=paddings, mode='REFLECT')
            res_net = slim.conv2d(res_net, num_filters * 4)
            res_net = tf.pad(tensor=res_net, paddings=paddings, mode='REFLECT')
            res_net = slim.conv2d(res_net, num_filters * 4, activation_fn=None)
    Severity: Major
    Found in research/slim/nets/cyclegan.py - About 45 mins to fix

      Function cyclegan_upsample has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def cyclegan_upsample(net, num_outputs, stride, method='conv2d_transpose',
      Severity: Minor
      Found in research/slim/nets/cyclegan.py - About 45 mins to fix

        Function cyclegan_arg_scope has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def cyclegan_arg_scope(instance_norm_center=True,
        Severity: Minor
        Found in research/slim/nets/cyclegan.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                net = tf.image.resize(
          net, [stride[0] * height, stride[1] * width],
          method=tf.image.ResizeMethod.NEAREST_NEIGHBOR)
          Severity: Major
          Found in research/slim/nets/cyclegan.py and 1 other location - About 2 hrs to fix
          research/slim/nets/pix2pix.py on lines 85..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            paddings = np.array(
      [[0, 0], [pad_top, pad_bottom], [pad_left, pad_right], [0, 0]],
      dtype=np.int32)
          Severity: Minor
          Found in research/slim/nets/cyclegan.py and 1 other location - About 40 mins to fix
          research/slim/nets/pix2pix.py on lines 251..253

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status