Sign upLogin

tensorflow/models

View on GitHub
Star
research/slim/nets/mobilenet/mobilenet_v3.py

Summary

Maintainability
D
2 days
Test Coverage

File mobilenet_v3.py has 665 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2019 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in research/slim/nets/mobilenet/mobilenet_v3.py - About 1 day to fix

    Function mobilenet has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def mobilenet(input_tensor,
    Severity: Major
    Found in research/slim/nets/mobilenet/mobilenet_v3.py - About 1 hr to fix

      Function mbv3_op has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def mbv3_op(ef, n, k, s=1, act=tf.nn.relu, se=None, **kwargs):
      Severity: Major
      Found in research/slim/nets/mobilenet/mobilenet_v3.py - About 50 mins to fix

        Function mbv3_fused has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def mbv3_fused(ef, n, k, s=1, **kwargs):
        Severity: Minor
        Found in research/slim/nets/mobilenet/mobilenet_v3.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          def hard_swish(x):
  with tf.name_scope('hard_swish'):
    return x * tf.nn.relu6(x + np.float32(3)) * np.float32(1. / 6.)
          Severity: Major
          Found in research/slim/nets/mobilenet/mobilenet_v3.py and 1 other location - About 3 hrs to fix
          research/object_detection/models/ssd_mobiledet_feature_extractor.py on lines 38..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            with slim.arg_scope((lib.depth_multiplier,), **depth_args):
    return lib.mobilenet(
          Severity: Major
          Found in research/slim/nets/mobilenet/mobilenet_v3.py and 1 other location - About 1 hr to fix
          research/slim/nets/mobilenet/mobilenet_v2.py on lines 174..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          @slim.add_arg_scope
def mobilenet_base(input_tensor, depth_multiplier=1.0, **kwargs):
  """Creates base of the mobilenet (no pooling and no logits) ."""
  return mobilenet(
          Severity: Minor
          Found in research/slim/nets/mobilenet/mobilenet_v3.py and 1 other location - About 30 mins to fix
          research/slim/nets/mobilenet/mobilenet_v2.py on lines 202..205

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status