Sign upLogin

tensorflow/models

View on GitHub
Star
research/slim/nets/mobilenet_v1.py

Summary

Maintainability
F
5 days
Test Coverage

File mobilenet_v1.py has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2017 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in research/slim/nets/mobilenet_v1.py - About 5 hrs to fix

    Function mobilenet_v1_base has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    def mobilenet_v1_base(inputs,
                      final_endpoint='Conv2d_13_pointwise',
                      min_depth=8,
                      depth_multiplier=1.0,
                      conv_defs=None,
    Severity: Minor
    Found in research/slim/nets/mobilenet_v1.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function mobilenet_v1 has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def mobilenet_v1(inputs,
    Severity: Major
    Found in research/slim/nets/mobilenet_v1.py - About 1 hr to fix

      Function mobilenet_v1_arg_scope has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def mobilenet_v1_arg_scope(
      Severity: Major
      Found in research/slim/nets/mobilenet_v1.py - About 1 hr to fix

        Function mobilenet_v1_base has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def mobilenet_v1_base(inputs,
        Severity: Major
        Found in research/slim/nets/mobilenet_v1.py - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                    if use_explicit_padding:
            net = _fixed_padding(net, conv_def.kernel)
          net = slim.conv2d(net, depth(conv_def.depth), conv_def.kernel,
          Severity: Major
          Found in research/slim/nets/mobilenet_v1.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      if end_point == final_endpoint:
            return net, end_points
            Severity: Major
            Found in research/slim/nets/mobilenet_v1.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                        if use_explicit_padding:
            net = _fixed_padding(net, conv_def.kernel, layer_rate)
          net = slim.separable_conv2d(net, None, conv_def.kernel,
              Severity: Major
              Found in research/slim/nets/mobilenet_v1.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                          if end_point == final_endpoint:
            return net, end_points
        else:
                Severity: Major
                Found in research/slim/nets/mobilenet_v1.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                            if end_point == final_endpoint:
            return net, end_points
                  Severity: Major
                  Found in research/slim/nets/mobilenet_v1.py - About 45 mins to fix

                    Function mobilenet_v1 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def mobilenet_v1(inputs,
                 num_classes=1000,
                 dropout_keep_prob=0.999,
                 is_training=True,
                 min_depth=8,
                    Severity: Minor
                    Found in research/slim/nets/mobilenet_v1.py - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    def _fixed_padding(inputs, kernel_size, rate=1):
  """Pads the input along the spatial dimensions independently of input size.

  Pads the input such that if it was used in a convolution with 'VALID' padding,
  the output would have the same dimensions as if the unpadded input was used
                    Severity: Major
                    Found in research/slim/nets/mobilenet_v1.py and 1 other location - About 2 days to fix
                    research/slim/nets/mobilenet/mobilenet.py on lines 34..59

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 261.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                    def _reduced_kernel_size_for_small_input(input_tensor, kernel_size):
  """Define kernel size which is automatically reduced for small input.

  If the shape of the input images is unknown at graph construction time this
  function assumes that the input images are large enough.
                    Severity: Major
                    Found in research/slim/nets/mobilenet_v1.py and 2 other locations - About 6 hrs to fix
                    research/slim/nets/inception_v2.py on lines 563..591
                    research/slim/nets/inception_v3.py on lines 552..580

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 107.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    def wrapped_partial(func, *args, **kwargs):
  partial_func = functools.partial(func, *args, **kwargs)
  functools.update_wrapper(partial_func, func)
  return partial_func
                    Severity: Minor
                    Found in research/slim/nets/mobilenet_v1.py and 1 other location - About 40 mins to fix
                    research/slim/nets/mobilenet/mobilenet_v2.py on lines 186..189

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 34.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status