Sign upLogin

tensorflow/models

View on GitHub
Star
research/slim/nets/resnet_utils.py

Summary

Maintainability
C
1 day
Test Coverage

Function stack_blocks_dense has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

def stack_blocks_dense(net, blocks, output_stride=None,
                       store_non_strided_activations=False,
                       outputs_collections=None):
  """Stacks ResNet `Blocks` and controls output feature density.
Severity: Minor
Found in research/slim/nets/resnet_utils.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function resnet_arg_scope has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def resnet_arg_scope(
Severity: Major
Found in research/slim/nets/resnet_utils.py - About 50 mins to fix

    Function conv2d_same has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def conv2d_same(inputs, num_outputs, kernel_size, stride, rate=1, scope=None):
    Severity: Minor
    Found in research/slim/nets/resnet_utils.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                if output_stride is not None and current_stride == output_stride:
            net = block.unit_fn(net, rate=rate, **dict(unit, stride=1))
            rate *= unit.get('stride', 1)

          else:
      Severity: Major
      Found in research/slim/nets/resnet_utils.py - About 45 mins to fix

        Function stack_blocks_dense has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def stack_blocks_dense(net, blocks, output_stride=None,
        Severity: Minor
        Found in research/slim/nets/resnet_utils.py - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    if output_stride is not None and current_stride == output_stride:
            net = block.unit_fn(net, rate=rate, **dict(unit, stride=1))
            rate *= unit.get('stride', 1)
          Severity: Major
          Found in research/slim/nets/resnet_utils.py and 1 other location - About 1 hr to fix
          research/deeplab/core/xception.py on lines 401..403

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              inputs = tf.pad(
        tensor=inputs,
        paddings=[[0, 0], [pad_beg, pad_end], [pad_beg, pad_end], [0, 0]])
          Severity: Minor
          Found in research/slim/nets/resnet_utils.py and 1 other location - About 35 mins to fix
          official/legacy/detection/modeling/architecture/resnet.py on lines 133..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status