Sign upLogin

tensorflow/tensorflow

View on GitHub
Star
tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py

Summary

Maintainability
F
2 wks
Test Coverage

File polymorphic_function_test.py has 3844 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2017 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 1 wk to fix

    FunctionTest has 218 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class FunctionTest(test.TestCase, parameterized.TestCase):

  def setUp(self):
    super().setUp()
    cpus = config.list_physical_devices('CPU')
    Severity: Major
    Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 4 days to fix

      MultiDeviceTest has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class MultiDeviceTest(test.TestCase, parameterized.TestCase):

  def testNestedCallWatchedVariables(self):

    v = variables.Variable(4.)
      Severity: Minor
      Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 2 hrs to fix

        Function testClone has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def testClone(self, input_signature, autograph, autograph_options, implements,
        Severity: Major
        Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 1 hr to fix

          Function testConcreteFunctionFlatSignatureError has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def testConcreteFunctionFlatSignatureError(self,
          Severity: Major
          Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 50 mins to fix

            Function testConcreteFunctionStructuredSignatureError has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def testConcreteFunctionStructuredSignatureError(self,
            Severity: Major
            Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 50 mins to fix

              Function test_pickle has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def test_pickle(self, input_signature, autograph, autograph_options,
              Severity: Minor
              Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 45 mins to fix

                Function dynamic_unroll has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def dynamic_unroll(core_fn,
                Severity: Minor
                Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 45 mins to fix

                  Function f5 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def f5(self, arg1, arg2, arg3, *args, **kwargs):
                  Severity: Minor
                  Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 35 mins to fix

                    Function testRetraceLogicWithSideInputs has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      def testRetraceLogicWithSideInputs(self, val_before, type_before, val_after,
                    Severity: Minor
                    Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 35 mins to fix

                      Function f3 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def f3(self, arg1, arg2, arg3, arg4=4, **kwargs):
                      Severity: Minor
                      Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 35 mins to fix

                        Function f3 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def f3(arg1, arg2, arg3, arg4=4, **kwargs):
                        Severity: Minor
                        Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 35 mins to fix

                          Function f5 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def f5(arg1, arg2, arg3, *args, **kwargs):
                          Severity: Minor
                          Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 35 mins to fix

                            Function test_variable_naming has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                              def test_variable_naming(self):
    class HasVars(module.Module):

      def __init__(self):
        self.x = None
                            Severity: Minor
                            Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function testWithExtraWrapperMissingArgs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                              def testWithExtraWrapperMissingArgs(self):

    class Foo(module.Module):

      def __init__(self):
                            Severity: Minor
                            Found in tensorflow/python/eager/polymorphic_function/polymorphic_function_test.py - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            There are no issues that match your filters.

                            Category
                            Status