Sign upLogin

tensorflow/tensorflow

View on GitHub
Star
tensorflow/python/saved_model/load_test.py

Summary

Maintainability
F
1 wk
Test Coverage

File load_test.py has 2766 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2018 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in tensorflow/python/saved_model/load_test.py - About 1 wk to fix

    LoadTest has 103 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LoadTest(test.TestCase, parameterized.TestCase):

  def test_structure_import(self, cycles, use_cpp_bindings):
    # TODO(b/264869228) Fix LoadTest
    if use_cpp_bindings:
    Severity: Major
    Found in tensorflow/python/saved_model/load_test.py - About 1 day to fix

      Function test_deferred_init_module_variables has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        def test_deferred_init_module_variables(self):
    """Defer initialization of variables in a module to the load stage."""

    class MyModule(module.Module):
      Severity: Minor
      Found in tensorflow/python/saved_model/load_test.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function cycle has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def cycle(
      Severity: Minor
      Found in tensorflow/python/saved_model/load_test.py - About 45 mins to fix

        Function foo has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def foo(self, a, b, c, d=10, **options):
        Severity: Minor
        Found in tensorflow/python/saved_model/load_test.py - About 35 mins to fix

          Function test_table_collections_untouched_eager has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def test_table_collections_untouched_eager(self, cycles, use_cpp_bindings):
    # TODO(b/264869228) Fix LoadTest
    if use_cpp_bindings:
      self.skipTest("Not implemented for cpp.")
          Severity: Minor
          Found in tensorflow/python/saved_model/load_test.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function test_positional_arguments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def test_positional_arguments(self, cycles, use_cpp_bindings):
    # TODO(b/264869228) Fix LoadTest
    if use_cpp_bindings:
      self.skipTest("Not implemented for cpp.")
          Severity: Minor
          Found in tensorflow/python/saved_model/load_test.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status