Sign upLogin

tensorflow/tensorflow

View on GitHub
Star
third_party/gpus/find_rocm_config.py

Summary

Maintainability
F
3 wks
Test Coverage

File find_rocm_config.py has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2020 The TensorFlow Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in third_party/gpus/find_rocm_config.py - About 4 hrs to fix

    Function _find_rocblas_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_rocblas_config(rocm_install_path):

  def rocblas_version_numbers(path):
    possible_version_files = [
        "include/rocblas/internal/rocblas-version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_hipruntime_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_hipruntime_config(rocm_install_path):

  def hipruntime_version_number(path):
    possible_version_files = [
        "include/hip/hip_version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_rocrand_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_rocrand_config(rocm_install_path):

  def rocrand_version_number(path):
    possible_version_files = [
        "include/rocrand/rocrand_version.h",  # ROCm 5.1
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_rocm_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_rocm_config(rocm_install_path):

  def rocm_version_numbers(path):
    possible_version_files = [
        "include/rocm-core/rocm_version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_rocfft_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_rocfft_config(rocm_install_path):

  def rocfft_version_numbers(path):
    possible_version_files = [
        "include/rocfft/rocfft-version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_hipfft_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_hipfft_config(rocm_install_path):

  def hipfft_version_numbers(path):
    possible_version_files = [
        "include/hipfft/hipfft-version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_miopen_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_miopen_config(rocm_install_path):

  def miopen_version_numbers(path):
    possible_version_files = [
        "include/miopen/version.h",  # ROCm 5.2 and prior
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_hipsparse_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_hipsparse_config(rocm_install_path):

  def hipsparse_version_numbers(path):
    possible_version_files = [
        "include/hipsparse/hipsparse-version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_roctracer_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_roctracer_config(rocm_install_path):

  def roctracer_version_numbers(path):
    possible_version_files = [
        "include/roctracer/roctracer.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_rocsolver_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_rocsolver_config(rocm_install_path):

  def rocsolver_version_numbers(path):
    possible_version_files = [
        "include/rocsolver/rocsolver-version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_hipsolver_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_hipsolver_config(rocm_install_path):

  def hipsolver_version_numbers(path):
    possible_version_files = [
        "include/hipsolver/internal/hipsolver-version.h",  # ROCm 5.2
    Severity: Minor
    Found in third_party/gpus/find_rocm_config.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    Severity: Major
    Found in third_party/gpus/find_rocm_config.py and 1 other location - About 3 wks to fix
    third_party/xla/third_party/tsl/third_party/gpus/find_rocm_config.py on lines 0..446

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 2141.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status