tensorflow/tensorflow

View on GitHub
third_party/xla/xla/python/xla_client.py

Summary

Maintainability
D
2 days
Test Coverage

File xla_client.py has 712 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2017 The OpenXLA Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in third_party/xla/xla/python/xla_client.py - About 1 day to fix

    Function window_padding_type_to_pad_values has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def window_padding_type_to_pad_values(
        padding_type, lhs_dims, rhs_dims, window_strides
    ):
      """Maps PaddingType or string to pad values (list of pairs of ints)."""
      if not isinstance(padding_type, (str, PaddingType)):
    Severity: Minor
    Found in third_party/xla/xla/python/xla_client.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __call__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def __call__(
    Severity: Minor
    Found in third_party/xla/xla/python/xla_client.py - About 45 mins to fix

      Function make_gpu_client has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def make_gpu_client(
      Severity: Minor
      Found in third_party/xla/xla/python/xla_client.py - About 45 mins to fix

        Function register_custom_call_target has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def register_custom_call_target(
        Severity: Minor
        Found in third_party/xla/xla/python/xla_client.py - About 35 mins to fix

          Function make_cpu_client has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def make_cpu_client(
          Severity: Minor
          Found in third_party/xla/xla/python/xla_client.py - About 35 mins to fix

            Function make_gpu_client has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            def make_gpu_client(
                distributed_client=None,
                node_id=0,
                num_nodes=1,
                platform_name=None,
            Severity: Minor
            Found in third_party/xla/xla/python/xla_client.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function shape_from_pyval has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def shape_from_pyval(pyval, layout: Sequence[int] | None = None):
              """Returns a Shape that describes a tuple-tree of Numpy arrays."""
            
              def convert(pyval):
                if isinstance(pyval, tuple):
            Severity: Minor
            Found in third_party/xla/xla/python/xla_client.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status