tensorflow/tensorflow

View on GitHub
third_party/xla/xla/python/xla_client_test.py

Summary

Maintainability
F
1 wk
Test Coverage

File xla_client_test.py has 2871 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2017 The OpenXLA Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Major
Found in third_party/xla/xla/python/xla_client_test.py - About 1 wk to fix

    Function TestFactory has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
    Open

    def TestFactory(xla_backend,
                    cloud_tpu=False,
                    tfrt_tpu=False,
                    pjrt_c_api=False,
                    pathways=False,
    Severity: Minor
    Found in third_party/xla/xla/python/xla_client_test.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function testApproxTopK has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def testApproxTopK(self):
          if self.backend.platform != "tpu":
            self.skipTest("ApproxTopK is only supported on TPU")
          k = 10
          qy_size = 256
    Severity: Minor
    Found in third_party/xla/xla/python/xla_client_test.py - About 1 hr to fix

      Function TestFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def TestFactory(xla_backend,
      Severity: Minor
      Found in third_party/xla/xla/python/xla_client_test.py - About 45 mins to fix

        Function _ExecuteAndCompareClose has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def _ExecuteAndCompareClose(self,
        Severity: Minor
        Found in third_party/xla/xla/python/xla_client_test.py - About 35 mins to fix

          Function _CompareToPyAndBufferProtocol has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def _CompareToPyAndBufferProtocol(self, builder, args, expected_results,
          Severity: Minor
          Found in third_party/xla/xla/python/xla_client_test.py - About 35 mins to fix

            Function testMemoryStats has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def testMemoryStats(self):
                  for device in self.backend.local_devices():
                    stats = device.memory_stats()
                    if (
                        self.backend.platform != "tpu" or not tfrt_tpu
            Severity: Minor
            Found in third_party/xla/xla/python/xla_client_test.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status