Sign upLogin

tensult/role-acl

View on GitHub
Star
src/conditions/util.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function evaluate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  public static evaluate(
    condition: ICondition,
    context: any
  ): boolean | Promise<boolean> {
    if (!condition) {
Severity: Minor
Found in src/conditions/util.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function evaluate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static evaluate(
    condition: ICondition,
    context: any
  ): boolean | Promise<boolean> {
    if (!condition) {
Severity: Minor
Found in src/conditions/util.ts - About 1 hr to fix

    Function validateCondition has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      public static validateCondition(condition) {
    if (!condition) {
      return;
    }
    Severity: Minor
    Found in src/conditions/util.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

              return ConditionUtil._customConditionFunctions[condition.Fn](context, condition.args);
    Severity: Major
    Found in src/conditions/util.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in src/conditions/util.ts - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status