Showing 1 of 1 total issue
Avoid using terabytesoft\helpers\count() function in for loops. Open
Open
for ($i = 0; $i < $length - count($sets); $i++) {
$password .= $all[array_rand($all)];
}- Read upRead up
- Exclude checks
CountInLoopExpression
Since: 2.7.0
Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.
Example
class Foo {
public function bar()
{
$array = array();
for ($i = 0; count($array); $i++) {
// ...
}
}
}