Sign upLogin

testmycode/tmc-server

View on GitHub
Star
app/controllers/submissions_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

Method create has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    if !params[:submission] || !params[:submission][:file]
      return respond_not_found('No ZIP file selected or failed to receive it')
    end
Severity: Minor
Found in app/controllers/submissions_controller.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_access! has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def check_access!
      if current_user.guest?
        raise CanCan::AccessDenied
      end
Severity: Minor
Found in app/controllers/submissions_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method show has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    @course ||= @submission.course
    @exercise ||= @submission.exercise
    @organization = @course.organization
Severity: Minor
Found in app/controllers/submissions_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File submissions_controller.rb has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'submission_processor'

# Receives submissions and presents the full submission list and submission view.
# Also handles rerun requests.
class SubmissionsController < ApplicationController
Severity: Minor
Found in app/controllers/submissions_controller.rb - About 3 hrs to fix

    Method show has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def show
    @course ||= @submission.course
    @exercise ||= @submission.exercise
    @organization = @course.organization
    Severity: Major
    Found in app/controllers/submissions_controller.rb - About 2 hrs to fix

      Method create has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create
    if !params[:submission] || !params[:submission][:file]
      return respond_not_found('No ZIP file selected or failed to receive it')
    end
      Severity: Major
      Found in app/controllers/submissions_controller.rb - About 2 hrs to fix

        Method check_access! has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def check_access!
      if current_user.guest?
        raise CanCan::AccessDenied
      end
        Severity: Minor
        Found in app/controllers/submissions_controller.rb - About 1 hr to fix

          Method difference_with_solution has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def difference_with_solution
    @course ||= @submission.course
    authorize! :teach, @course
    @exercise ||= @submission.exercise
    @organization = @course.organization
          Severity: Minor
          Found in app/controllers/submissions_controller.rb - About 1 hr to fix

            Method difference_with_solution has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def difference_with_solution
    @course ||= @submission.course
    authorize! :teach, @course
    @exercise ||= @submission.exercise
    @organization = @course.organization
            Severity: Minor
            Found in app/controllers/submissions_controller.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def index
    respond_to do |format|
      format.json do
        if params[:row_format] == 'datatables'
          index_json_datatables
            Severity: Minor
            Found in app/controllers/submissions_controller.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                        return
            Severity: Major
            Found in app/controllers/submissions_controller.rb - About 30 mins to fix

              Method get_course_and_exercise has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_course_and_exercise
      submission_id = params[:id] || params[:submission_id]
      if submission_id
        @submission = Submission.find(submission_id)
        authorize! :read, @submission
              Severity: Minor
              Found in app/controllers/submissions_controller.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method index_json_datatables has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def index_json_datatables
      submissions = @course.submissions

      unless current_user.administrator? || can?(:teach, @course)
        submissions = submissions.where(user_id: current_user.id)
              Severity: Minor
              Found in app/controllers/submissions_controller.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      output = output.merge(
          case @submission.status(current_user)
          when :processing then {
            submissions_before_this: @submission.unprocessed_submissions_before_this,
            total_unprocessed: Submission.unprocessed_count
              Severity: Major
              Found in app/controllers/submissions_controller.rb and 1 other location - About 2 hrs to fix
              app/controllers/api/v8/core/submissions_controller.rb on lines 83..106

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status