Sign upLogin

testmycode/tmc-server

View on GitHub
Star
app/helpers/submissions_helper.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method submission_review_column has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def submission_review_column(submission)
    if submission.reviewed?
      if can? :create_review, submission.course
        link_to 'Available', new_submission_review_path(submission)
      else
Severity: Minor
Found in app/helpers/submissions_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method submission_review_column has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def submission_review_column(submission)
    if submission.reviewed?
      if can? :create_review, submission.course
        link_to 'Available', new_submission_review_path(submission)
      else
Severity: Minor
Found in app/helpers/submissions_helper.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

        elsif submission.requires_review?
      if can? :create_review, submission.course
        link_to 'Required', new_submission_review_path(submission)
      else
        'Pending'
    Severity: Major
    Found in app/helpers/submissions_helper.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

            if can? :create_review, submission.course
        link_to 'Requested', new_submission_review_path(submission)
      else
        'Requested'
      end
      Severity: Major
      Found in app/helpers/submissions_helper.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status