app/models/unlock_spec.rb
Method parse_condition
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
Open
def parse_condition(str)
if DateAndTimeUtils.looks_like_date_or_time(str)
time = DateAndTimeUtils.to_time(str)
raise 'Date out of range' if time.year > 10_000 || time.year < 1 # Prevent database datetime overflow
raise "You can't have multiple unlock dates for the same exercise" if @datetime_count > 0 # Multiple unlock dates don't work correctly
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse_condition
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def parse_condition(str)
if DateAndTimeUtils.looks_like_date_or_time(str)
time = DateAndTimeUtils.to_time(str)
raise 'Date out of range' if time.year > 10_000 || time.year < 1 # Prevent database datetime overflow
raise "You can't have multiple unlock dates for the same exercise" if @datetime_count > 0 # Multiple unlock dates don't work correctly
Avoid deeply nested control flow statements. Open
Open
if remaining > 0
"get #{remaining} more #{plural(remaining, 'point')} from #{group}"
end