Sign upLogin

testmycode/tmc-server

View on GitHub
Star
lib/course_info.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method exercise_data has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def exercise_data(exercise)
      return nil unless exercise.visible_to?(@user)

      # optimization: use @unlocked_exercises to avoid querying unlocks repeatedly
      locked = exercise.requires_unlock? && !@unlocked_exercises.include?(exercise.name)
Severity: Minor
Found in lib/course_info.rb - About 1 hr to fix

    Method course_data_core_api has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def course_data_core_api(course)
    # UncomputedUnlock.resolve(course, @user)
    @unlocked_exercises = course.unlocks
                                .where(user_id: @user.id)
                                .where(['valid_after IS NULL OR valid_after < ?', Time.now])
    Severity: Minor
    Found in lib/course_info.rb - About 1 hr to fix

      Method exercise_data_core_api has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def exercise_data_core_api(exercise)
      # optimization: use @unlocked_exercises to avoid querying unlocks repeatedly
      locked = exercise.requires_unlock? && !@unlocked_exercises.include?(exercise.name)
      show_points = !exercise.hide_submission_results? && !exercise.course.hide_submission_results?
      attempted = exercise.attempted_by?(@user)
      Severity: Minor
      Found in lib/course_info.rb - About 1 hr to fix

        Method exercise_data has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def exercise_data(exercise)
      return nil unless exercise.visible_to?(@user)

      # optimization: use @unlocked_exercises to avoid querying unlocks repeatedly
      locked = exercise.requires_unlock? && !@unlocked_exercises.include?(exercise.name)
        Severity: Minor
        Found in lib/course_info.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method course_data_core_api has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def course_data_core_api(course)
    # UncomputedUnlock.resolve(course, @user)
    @unlocked_exercises = course.unlocks
                                .where(user_id: @user.id)
                                .where(['valid_after IS NULL OR valid_after < ?', Time.now])
        Severity: Minor
        Found in lib/course_info.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status