Sign upLogin

testmycode/tmc-server

View on GitHub
Star
lib/gdocs_export.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method write_points has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def self.write_points(ws, course, students, points)
    students.each do |student|
      row = student_row ws, student.login
      raise "student #{student.login} not found" if row < 0
      awarded = AwardedPoint.course_user_sheet_points(course, student, ws.title).map(&:name)
Severity: Minor
Found in lib/gdocs_export.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method student_row has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def self.student_row(ws, student_name)
    stripped = strip_leading_zeroes(student_name)
    return -1 if stripped.empty?

    (header_row + 1..ws.num_rows).each do |row|
Severity: Minor
Found in lib/gdocs_export.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def self.authenticate(notifications)
    notifications << 'gdocs_username undefined' && (return nil) unless
      TmcServer::Application.config.gdocs_username
    notifications << 'gdocs_password undefined' && (return nil) unless
      TmcServer::Application.config.gdocs_password
Severity: Minor
Found in lib/gdocs_export.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status