Sign upLogin

testmycode/tmc-server

View on GitHub
Star
lib/kafka_updater.rb

Summary

Maintainability
D
1 day
Test Coverage

Method update_course_points has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update_course_points(task)
    finished_successfully = false
    course = Course.find(task.course_id)
    Rails.logger.info("Batch publishing points for course #{course.name} with moocfi id: #{course.moocfi_id}")
    if !course.moocfi_id
Severity: Minor
Found in lib/kafka_updater.rb - About 1 hr to fix

    Method update_user_course_points has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def update_user_course_points(task)
    finished_successfully = false
    course = Course.find(task.course_id)
    user = User.find(task.user_id)
    Rails.logger.info("Publishing points for user #{user.id} with moocfi id: #{course.moocfi_id}.")
    Severity: Minor
    Found in lib/kafka_updater.rb - About 1 hr to fix

      Method update_course_progress has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def update_course_progress(task)
    finished_successfully = false
    course = Course.find(task.course_id)
    Rails.logger.info("Batch publishing progress for course #{course.name} with moocfi id: #{course.moocfi_id}.")
    if !course.moocfi_id
      Severity: Minor
      Found in lib/kafka_updater.rb - About 1 hr to fix

        Method update_user_progress has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def update_user_progress(task)
    finished_successfully = false
    user = User.find(task.user_id)
    course = Course.find(task.course_id)
    Rails.logger.info("Publishing progress for user #{user.id} with moocfi id: #{course.moocfi_id}.")
        Severity: Minor
        Found in lib/kafka_updater.rb - About 1 hr to fix

          Method update_exercises has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def update_exercises(task)
    finished_successfully = false
    course = Course.find(task.course_id)
    Rails.logger.info("Batch publishing exercises for course #{course.name} with moocfi id: #{course.moocfi_id}.")
    if !course.moocfi_id
          Severity: Minor
          Found in lib/kafka_updater.rb - About 1 hr to fix

            Method update_user_points has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def update_user_points(task)
    finished_successfully = false
    course = Course.find(task.course_id)
    user = User.find(task.user_id)
    Rails.logger.info("Publishing points for user #{user.id} with moocfi id: #{course.moocfi_id}.")
            Severity: Minor
            Found in lib/kafka_updater.rb - About 1 hr to fix

              Method update_user_progress has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def update_user_progress(task)
    finished_successfully = false
    user = User.find(task.user_id)
    course = Course.find(task.course_id)
    Rails.logger.info("Publishing progress for user #{user.id} with moocfi id: #{course.moocfi_id}.")
              Severity: Minor
              Found in lib/kafka_updater.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update_course_points has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def update_course_points(task)
    finished_successfully = false
    course = Course.find(task.course_id)
    Rails.logger.info("Batch publishing points for course #{course.name} with moocfi id: #{course.moocfi_id}")
    if !course.moocfi_id
              Severity: Minor
              Found in lib/kafka_updater.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update_user_course_points has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def update_user_course_points(task)
    finished_successfully = false
    course = Course.find(task.course_id)
    user = User.find(task.user_id)
    Rails.logger.info("Publishing points for user #{user.id} with moocfi id: #{course.moocfi_id}.")
              Severity: Minor
              Found in lib/kafka_updater.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      awarded_points = exercise.points_for(current_user)
        completed = exercise.completed_by?(current_user)
        user_submissions = exercise.submissions_by(current_user)
        attempted = user_submissions.length > 0
        original_submission_date = user_submissions.pluck(:created_at).sort.first
              Severity: Major
              Found in lib/kafka_updater.rb and 1 other location - About 1 hr to fix
              lib/kafka_updater.rb on lines 227..245

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    awarded_points = exercise.points_for(user)
      completed = exercise.completed_by?(user)
      user_submissions = exercise.submissions_by(user)
      attempted = user_submissions.length > 0
      original_submission_date = user_submissions.pluck(:created_at).sort.first
              Severity: Major
              Found in lib/kafka_updater.rb and 1 other location - About 1 hr to fix
              lib/kafka_updater.rb on lines 147..165

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      max_points = available_points[group_name] || 0
        stupid_name = "osa#{group_name.tr('^0-9', '').rjust(2, "0")}"
        {
          group: stupid_name,
          n_points: awarded_points,
              Severity: Minor
              Found in lib/kafka_updater.rb and 1 other location - About 25 mins to fix
              lib/kafka_updater.rb on lines 34..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    max_points = available_points[group_name] || 0
      stupid_name = "osa#{group_name.tr('^0-9', '').rjust(2, "0")}"
      {
        group: stupid_name,
        n_points: awarded_points,
              Severity: Minor
              Found in lib/kafka_updater.rb and 1 other location - About 25 mins to fix
              lib/kafka_updater.rb on lines 74..81

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status