Sign upLogin

tflori/hugga

View on GitHub
Star
src/Output/Drawing/Table.php

Summary

Maintainability
D
2 days
Test Coverage
A
100%

File Table.php has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Hugga\Output\Drawing;

use Hugga\Console;
Severity: Minor
Found in src/Output/Drawing/Table.php - About 5 hrs to fix

    Function getRows has a Cognitive Complexity of 28 (exceeds 9 allowed). Consider refactoring.
    Open

        protected function getRows(iterable $data): array
    {
        $rows = [];
        list($left, $right, $spacer) = $this->getDivider();
    Severity: Minor
    Found in src/Output/Drawing/Table.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Table has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Table implements DrawingInterface
{
    const CORNER_TOP_LEFT = 'ctl';
    const CORNER_TOP_RIGHT = 'ctr';
    const CORNER_BOTTOM_LEFT = 'cbl';
    Severity: Minor
    Found in src/Output/Drawing/Table.php - About 2 hrs to fix

      Method getRows has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getRows(iterable $data): array
    {
        $rows = [];
        list($left, $right, $spacer) = $this->getDivider();
      Severity: Minor
      Found in src/Output/Drawing/Table.php - About 1 hr to fix

        Method prepareColumns has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function prepareColumns()
    {
        if ($this->columns) {
            return;
        }
        Severity: Minor
        Found in src/Output/Drawing/Table.php - About 1 hr to fix

          Function prepareColumns has a Cognitive Complexity of 16 (exceeds 9 allowed). Consider refactoring.
          Open

              protected function prepareColumns()
    {
        if ($this->columns) {
            return;
        }
          Severity: Minor
          Found in src/Output/Drawing/Table.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getText has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getText(): string
    {
        $this->prepareColumns();
        $rows = [];
          Severity: Minor
          Found in src/Output/Drawing/Table.php - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Wontfix

                            if (is_object($row) && property_exists($row, $key) ||
                    is_array($row) && array_key_exists($key, $row) ||
                    ($row instanceof \ArrayAccess) && $row->offsetExists($key)
                ) {
                    $fallback = 'null';
            Severity: Major
            Found in src/Output/Drawing/Table.php - About 40 mins to fix

              Function getText has a Cognitive Complexity of 11 (exceeds 9 allowed). Consider refactoring.
              Open

                  public function getText(): string
    {
        $this->prepareColumns();
        $rows = [];
              Severity: Minor
              Found in src/Output/Drawing/Table.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function getBottomBorderRow()
    {
        $r = [];
        foreach ($this->columns as $column) {
            $r[] = str_repeat($this->borderStyle[self::BORDER_HORIZONTAL], $column->width + $this->padding * 2);
              Severity: Major
              Found in src/Output/Drawing/Table.php and 1 other location - About 1 hr to fix
              src/Output/Drawing/Table.php on lines 499..509

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function getTopBorderRow()
    {
        $r = [];
        foreach ($this->columns as $column) {
            $r[] = str_repeat($this->borderStyle[self::BORDER_HORIZONTAL], $column->width + $this->padding * 2);
              Severity: Major
              Found in src/Output/Drawing/Table.php and 1 other location - About 1 hr to fix
              src/Output/Drawing/Table.php on lines 511..521

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected $borderStyle = [
        self::CORNER_TOP_LEFT => '╭',
        self::CORNER_TOP_RIGHT => '╮',
        self::CORNER_BOTTOM_LEFT => '╰',
        self::CORNER_BOTTOM_RIGHT => '╯',
              Severity: Minor
              Found in src/Output/Drawing/Table.php and 1 other location - About 30 mins to fix
              src/Output/Drawing/Table.php on lines 28..40

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      'borderStyle' => [
            self::CORNER_TOP_LEFT => '╭',
            self::CORNER_TOP_RIGHT => '╮',
            self::CORNER_BOTTOM_LEFT => '╰',
            self::CORNER_BOTTOM_RIGHT => '╯',
              Severity: Minor
              Found in src/Output/Drawing/Table.php and 1 other location - About 30 mins to fix
              src/Output/Drawing/Table.php on lines 55..67

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 90.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status