Sign upLogin

thatandromeda/hamlet

View on GitHub
Star
hamlet/citations/extract_refs.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _reprocess_bad has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def _reprocess_bad(good, bad):
    for handle in bad.keys():
        filteredbad = [refdict for refdict in bad[handle]
                       if refdict and len(refdict['raw_ref'][0]) < 200]
Severity: Minor
Found in hamlet/citations/extract_refs.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _find_candidate_refs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def _find_candidate_refs(reftuples):
    # Given citation data associated with various filenames, classify the
    # citations as good or bad.
    #
    # :param reftuples: list of tuples of (filename, list of dictd of citation
Severity: Minor
Found in hamlet/citations/extract_refs.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status