Sign upLogin

thcolin/scene-release-parser

View on GitHub
Star

Showing 37 of 37 total issues

File Release.php has 756 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

  namespace thcolin\SceneReleaseParser;

  use Mhor\MediaInfo\MediaInfo;
Severity: Major
Found in src/Release.php - About 1 day to fix

    Function execute has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output){
      $verbose = !$input -> getOption('non-verbose');
      $interactive = !$input -> getOption('non-interactive');
      $invasive = !$input -> getOption('non-invasive');
    Severity: Minor
    Found in src/Command/RenamerCommand.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function analyse has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function analyse($path, $config = []){
      if(!is_file($path)){
        throw new InvalidArgumentException("File '".$path."' not found");
      }
    Severity: Minor
    Found in src/Release.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method correct has 182 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function correct(InputInterface $input, OutputInterface $output, Release $release){
      $done = false;

      do{
        $output->writeln('');
    Severity: Major
    Found in src/Command/RenamerCommand.php - About 7 hrs to fix

      Release has 45 functions (exceeds 20 allowed). Consider refactoring.
      Open

        class Release{

    const MOVIE = 'movie';
    const TVSHOW = 'tvshow';
      Severity: Minor
      Found in src/Release.php - About 6 hrs to fix

        Method execute has 119 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output){
      $verbose = !$input -> getOption('non-verbose');
      $interactive = !$input -> getOption('non-interactive');
      $invasive = !$input -> getOption('non-invasive');
        Severity: Major
        Found in src/Command/RenamerCommand.php - About 4 hrs to fix

          File RenamerCommand.php has 332 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

  namespace thcolin\SceneReleaseParser\Command;

  use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
          Severity: Minor
          Found in src/Command/RenamerCommand.php - About 4 hrs to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                      case 'encoding':
            $values = array_keys(Release::$encodingStatic);
            $question = new ChoiceQuestion('<question>Select encoding :</question> ', $values);
            $question -> setAutocompleterValues($values);
            $question -> setValidator(function($answer) use ($values){
            Severity: Major
            Found in src/Command/RenamerCommand.php and 3 other locations - About 3 hrs to fix
            src/Command/RenamerCommand.php on lines 270..287
            src/Command/RenamerCommand.php on lines 288..305
            src/Command/RenamerCommand.php on lines 306..323

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                      case 'resolution':
            $values = array_keys(Release::$resolutionStatic);
            $question = new ChoiceQuestion('<question>Select resolution :</question> ', $values);
            $question -> setAutocompleterValues($values);
            $question -> setValidator(function($answer) use ($values){
            Severity: Major
            Found in src/Command/RenamerCommand.php and 3 other locations - About 3 hrs to fix
            src/Command/RenamerCommand.php on lines 288..305
            src/Command/RenamerCommand.php on lines 306..323
            src/Command/RenamerCommand.php on lines 324..341

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                      case 'source':
            $values = array_keys(Release::$sourceStatic);
            $question = new ChoiceQuestion('<question>Select source :</question> ', $values);
            $question -> setAutocompleterValues($values);
            $question -> setValidator(function($answer) use ($values){
            Severity: Major
            Found in src/Command/RenamerCommand.php and 3 other locations - About 3 hrs to fix
            src/Command/RenamerCommand.php on lines 270..287
            src/Command/RenamerCommand.php on lines 306..323
            src/Command/RenamerCommand.php on lines 324..341

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                      case 'dub':
            $values = array_keys(Release::$dubStatic);
            $question = new ChoiceQuestion('<question>Select dub :</question> ', $values);
            $question -> setAutocompleterValues($values);
            $question -> setValidator(function($answer) use ($values){
            Severity: Major
            Found in src/Command/RenamerCommand.php and 3 other locations - About 3 hrs to fix
            src/Command/RenamerCommand.php on lines 270..287
            src/Command/RenamerCommand.php on lines 288..305
            src/Command/RenamerCommand.php on lines 324..341

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 159.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method analyse has 94 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function analyse($path, $config = []){
      if(!is_file($path)){
        throw new InvalidArgumentException("File '".$path."' not found");
      }
            Severity: Major
            Found in src/Release.php - About 3 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        case 'episode':
            $question = new Question('<question>Replace old episode # :</question> ');
            $question -> setAutocompleterValues([$release -> getEpisode()]);
            $question -> setValidator(function($answer){
              if(!$answer){
              Severity: Major
              Found in src/Command/RenamerCommand.php and 1 other location - About 2 hrs to fix
              src/Command/RenamerCommand.php on lines 348..366

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        case 'season':
            $question = new Question('<question>Replace old season # :</question> ');
            $question -> setAutocompleterValues([$release -> getSeason()]);
            $question -> setValidator(function($answer){
              if(!$answer){
              Severity: Major
              Found in src/Command/RenamerCommand.php and 1 other location - About 2 hrs to fix
              src/Command/RenamerCommand.php on lines 367..385

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function parseLanguage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function parseLanguage(&$title){
      $languages = [];

      foreach(self::$languageStatic as $langue => $patterns){
        if(!is_array($patterns)){
              Severity: Minor
              Found in src/Release.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function correct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function correct(InputInterface $input, OutputInterface $output, Release $release){
      $done = false;

      do{
        $output->writeln('');
              Severity: Minor
              Found in src/Command/RenamerCommand.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct($name, $strict = true, $defaults = []){
      foreach($defaults as $key => $default){
        $const = $key.'Static';

        if(property_exists(get_class(), $const) && !in_array($default, array_keys(self::$$const))){
              Severity: Minor
              Found in src/Release.php - About 1 hr to fix

                Function guessResolution has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function guessResolution(){
      if($this -> resolution){
        return $this -> resolution;
      } else if($this->getSource() == self::SOURCE_BLURAY || $this->getSource() == self::SOURCE_BDSCR){
        return self::RESOLUTION_1080P;
                Severity: Minor
                Found in src/Release.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parseAttribute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function parseAttribute(&$title, $attribute){
      if(!in_array($attribute, [self::SOURCE, self::ENCODING, self::RESOLUTION, self::DUB])){
        throw new InvalidArgumentException();
      }
                Severity: Minor
                Found in src/Release.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parseFlags has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function parseFlags(&$title){
      $flags = [];

      foreach(self::$flagsStatic as $key => $patterns){
        if(!is_array($patterns)){
                Severity: Minor
                Found in src/Release.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language