Sign upLogin

the-kbA-team/cache

View on GitHub
Star

Showing 2 of 6 total issues

Missing class import via use statement (line '72', column '23').
Open

        $client = new \Redis();
Severity: Minor
Found in src/Redis.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getMultipleFromArray uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                /** @noinspection UnserializeExploitsInspection */
                $value = unserialize($valueSerialized);
            }
Severity: Minor
Found in src/Redis.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language