Sign upLogin

theBenForce/jalexa

View on GitHub
Star

Showing 13 of 16 total issues

Function buildCanHandleIntentRequest has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const buildCanHandleIntentRequest = (skillId: string) => (
  props: BuildCanHandleIntentRequestProps
): ASKAPI.Request<ASKAPI.CanFulfillIntentRequest> => {
  if (!props.sessionId) {
    props.sessionId = `SessionId.${UUID.v4()}`;
Severity: Major
Found in src/requests/canHandleIntent.ts - About 2 hrs to fix

    Function toHaveSlot has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function toHaveSlot(
  received: AlexaSimulationResult,
  slotName: string,
  value?: string
) {
    Severity: Minor
    Found in src/matchers/responses.ts - About 1 hr to fix

      Function connectionCheck has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function connectionCheck(
  received: AlexaSimulationResult,
  name: string,
  productId?: string
) {
      Severity: Minor
      Found in src/matchers/directives/index.ts - About 1 hr to fix

        Function resetIspEntitlement has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async resetIspEntitlement(referenceName: string): Promise<void> {
    const products: Array<InSkillProductSummary> = await new Promise(
      (resolve, reject) =>
        this.controller.smapiClient.isp.listIspForSkill(
          this.params.skillId,
        Severity: Minor
        Found in src/index.ts - About 1 hr to fix

          Function buildCanHandleIntentRequest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          export const buildCanHandleIntentRequest = (skillId: string) => (
  props: BuildCanHandleIntentRequestProps
): ASKAPI.Request<ASKAPI.CanFulfillIntentRequest> => {
  if (!props.sessionId) {
    props.sessionId = `SessionId.${UUID.v4()}`;
          Severity: Minor
          Found in src/requests/canHandleIntent.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function toHaveSlot has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          export function toHaveSlot(
  received: AlexaSimulationResult,
  slotName: string,
  value?: string
) {
          Severity: Minor
          Found in src/matchers/responses.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              return directive
      ? {
          pass: true,
          message: () =>
            `Expected directives [${directives
          Severity: Minor
          Found in src/matchers/directives/index.ts and 1 other location - About 55 mins to fix
          src/matchers/directives/index.ts on lines 9..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            return directives.find((directive) => directive.type === directiveType)
    ? {
        pass: true,
        message: () =>
          `Expected directives [${directives
          Severity: Minor
          Found in src/matchers/directives/index.ts and 1 other location - About 55 mins to fix
          src/matchers/directives/index.ts on lines 38..56

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export function isIntentRequest(request: BasicRequest<RequestTypes>): request is IntentRequest {
  return request.type === RequestTypes.IntentRequest;
}
          Severity: Major
          Found in src/responses.ts and 3 other locations - About 50 mins to fix
          src/responses.ts on lines 16..18
          src/responses.ts on lines 23..25
          src/responses.ts on lines 83..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export function isLaunchRequest(request: BasicRequest<RequestTypes>): request is LaunchRequest {
  return request.type === RequestTypes.LaunchRequest;
}
          Severity: Major
          Found in src/responses.ts and 3 other locations - About 50 mins to fix
          src/responses.ts on lines 23..25
          src/responses.ts on lines 62..64
          src/responses.ts on lines 83..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export function isSessionEndedRequest(request: BasicRequest<RequestTypes>): request is SessionEndedRequest {
  return request.type === RequestTypes.SessionEndedRequest;
}
          Severity: Major
          Found in src/responses.ts and 3 other locations - About 50 mins to fix
          src/responses.ts on lines 16..18
          src/responses.ts on lines 23..25
          src/responses.ts on lines 62..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export function isCanFulfillIntentRequest(request: BasicRequest<RequestTypes>): request is CanFulfillIntentRequest {
  return request.type === RequestTypes.CanFulfillIntentRequest;
}
          Severity: Major
          Found in src/responses.ts and 3 other locations - About 50 mins to fix
          src/responses.ts on lines 16..18
          src/responses.ts on lines 62..64
          src/responses.ts on lines 83..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function connectionCheck has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function connectionCheck(
  received: AlexaSimulationResult,
  name: string,
  productId?: string
) {
          Severity: Minor
          Found in src/matchers/directives/index.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language