thedrummeraki/tanoshimu

View on GitHub
app/models/show.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Show has 49 methods (exceeds 20 allowed). Consider refactoring.
Open

class Show < ApplicationRecord
  include ShowScopesConcern
  include LikeableConcern
  include TanoshimuUtils::Concerns::RespondToTypes
  include TanoshimuUtils::Concerns::ResourceFetch
Severity: Minor
Found in app/models/show.rb - About 6 hrs to fix

    File show.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require_relative 'active_storage'
    
    class Show < ApplicationRecord
      include ShowScopesConcern
      include LikeableConcern
    Severity: Minor
    Found in app/models/show.rb - About 4 hrs to fix

      Method update_banner_and_poster_urls! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_banner_and_poster_urls!(**options)
          force = options[:force] || false
          return nil unless persisted?
          if !force
            return true if poster_url? && banner_url?
      Severity: Minor
      Found in app/models/show.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method sort_filters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.sort_filters(*filters)
          scope = all
          filters.map do |filter|
            scope = if filter.use_scope
              scope = scope.send(filter.use_scope)
      Severity: Minor
      Found in app/models/show.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status