Sign upLogin

theforeman/foreman

View on GitHub
Star
app/assets/javascripts/host_edit.js

Summary

Maintainability
F
4 days
Test Coverage

File host_edit.js has 860 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//= require parameter_override

$(document).ready(function() {
  var searchParams = new URLSearchParams(window.location.search);
  if(searchParams.has('hostgroup_id')) {
Severity: Major
Found in app/assets/javascripts/host_edit.js - About 2 days to fix

    Function interface_subnet_selected has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function interface_subnet_selected(element, ip_field, skip_mac) {
  // mark the selected value to preserve it for form hiding
  preserve_selected_options($(element));

  if ($(element).attr('disabled')) return;
    Severity: Major
    Found in app/assets/javascripts/host_edit.js - About 3 hrs to fix

      Function update_provisioning_image has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

      function update_provisioning_image() {
  var compute_id = $('[name$="[compute_resource_id]"]').val();
  var arch_id = $('[name$="[architecture_id]"]').val();
  var os_id = $('[name$="[operatingsystem_id]"]').val();
  if (
      Severity: Minor
      Found in app/assets/javascripts/host_edit.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function interface_domain_selected has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function interface_domain_selected(element) {
  // mark the selected value to preserve it for form hiding
  preserve_selected_options($(element));

  var domain_id = element.value;
      Severity: Minor
      Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

        Function interface_subnet_selected has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        function interface_subnet_selected(element, ip_field, skip_mac) {
  // mark the selected value to preserve it for form hiding
  preserve_selected_options($(element));

  if ($(element).attr('disabled')) return;
        Severity: Minor
        Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function computeResourceSelected has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function computeResourceSelected(item) {
  providerSpecificNICInfo = null;
  var compute = $(item).val();
  if (compute == '' && /compute_resource/.test($(item).attr('name'))) {
    //Bare metal compute resource
        Severity: Minor
        Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

          Function update_provisioning_image has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function update_provisioning_image() {
  var compute_id = $('[name$="[compute_resource_id]"]').val();
  var arch_id = $('[name$="[architecture_id]"]').val();
  var os_id = $('[name$="[operatingsystem_id]"]').val();
  if (
          Severity: Minor
          Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

            Function selectRelatedNetwork has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function selectRelatedNetwork(subnetElement) {
  var subnet_select = $(subnetElement);
  var vlanId = subnet_select.find(':selected').attr('data-vlan_id');
  var network_select = subnet_select
    .closest('fieldset')
            Severity: Minor
            Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

              Function submit_with_all_params has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function submit_with_all_params() {
  $('form.hostresource-form input[type="submit"]').attr('disabled', true);
  stop_pooling = false;
  $('body').css('cursor', 'progress');
  clear_errors();
              Severity: Minor
              Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

                Function update_capabilities has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function update_capabilities(capabilities) {
  capabilities = capabilities.split(' ');
  $('#image_provisioning').empty();
  $('#image_selection').appendTo($('#image_provisioning'));
  update_provisioning_image();
                Severity: Minor
                Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

                  Function update_form has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function update_form(element, options) {
  options = options || {};
  var url = $(element).data('url');
  var data = serializeForm().replace('method=patch', 'method=post');
  if (options.data) data = data + options.data;
                  Severity: Minor
                  Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

                    Function pxeLoaderCompatibilityCheck has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function pxeLoaderCompatibilityCheck() {
  var pxeLoader = $('#host_pxe_loader').val();
  var osTitle = $('#host_operatingsystem_id option:selected').text();
  var compatible = tfm.hosts.checkPXELoaderCompatibility(osTitle, pxeLoader);
  if (compatible === false) {
                    Severity: Minor
                    Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

                      Function update_form has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function update_form(element, options) {
  options = options || {};
  var url = $(element).data('url');
  var data = serializeForm().replace('method=patch', 'method=post');
  if (options.data) data = data + options.data;
                      Severity: Minor
                      Found in app/assets/javascripts/host_edit.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function interface_domain_selected has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function interface_domain_selected(element) {
  // mark the selected value to preserve it for form hiding
  preserve_selected_options($(element));

  var domain_id = element.value;
                      Severity: Minor
                      Found in app/assets/javascripts/host_edit.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function update_capabilities has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function update_capabilities(capabilities) {
  capabilities = capabilities.split(' ');
  $('#image_provisioning').empty();
  $('#image_selection').appendTo($('#image_provisioning'));
  update_provisioning_image();
                      Severity: Minor
                      Found in app/assets/javascripts/host_edit.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function submit_with_all_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function submit_with_all_params() {
  $('form.hostresource-form input[type="submit"]').attr('disabled', true);
  stop_pooling = false;
  $('body').css('cursor', 'progress');
  clear_errors();
                      Severity: Minor
                      Found in app/assets/javascripts/host_edit.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function computeResourceSelected has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function computeResourceSelected(item) {
  providerSpecificNICInfo = null;
  var compute = $(item).val();
  if (compute == '' && /compute_resource/.test($(item).attr('name'))) {
    //Bare metal compute resource
                      Severity: Minor
                      Found in app/assets/javascripts/host_edit.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                            $.each(result, function() {
        image_options.append(
          $('<option />')
            .val(this.uuid)
            .text(this.name)
                      Severity: Major
                      Found in app/assets/javascripts/host_edit.js and 1 other location - About 1 hr to fix
                      webpack/assets/javascripts/compute_resource/ovirt.js on lines 215..221

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 56.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status