theforeman/foreman

File host_edit.js has 860 lines of code (exceeds 250 allowed). Consider refactoring.

Open

//= require parameter_override

$(document).ready(function() {
  var searchParams = new URLSearchParams(window.location.search);
  if(searchParams.has('hostgroup_id')) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('vertical movement', () => {
      beforeEach(() => {
        setup('vertical')
      });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('horizontal movement', () => {
      beforeEach(() => {
        setup('horizontal')
      });

• Read up
  Read up

File hosts_controller.rb has 796 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class HostsController < ApplicationController
  include Foreman::Controller::ActionPermissionDsl
  include ScopesPerAction
  include Foreman::Controller::HostDetails
  include Foreman::Controller::AutoCompleteSearch

Class Managed has 97 methods (exceeds 20 allowed). Consider refactoring.

Open

class Host::Managed < Host::Base
  # audit the changes to this model
  audited :except => [:last_report, :last_compile, :lookup_value_matcher, :global_status]
  has_associated_audits
  # redefine audits relation because of the type change (by default the relation will look for auditable_type = 'Host::Managed')

File managed.rb has 774 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class Host::Managed < Host::Base
  # audit the changes to this model
  audited :except => [:last_report, :last_compile, :lookup_value_matcher, :global_status]
  has_associated_audits
  # redefine audits relation because of the type change (by default the relation will look for auditable_type = 'Host::Managed')

File vmware.rb has 719 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'fog_extensions/vsphere/mini_servers'
require 'foreman/exception'

begin
  require 'rbvmomi'

Class ComputeResource has 84 methods (exceeds 20 allowed). Consider refactoring.

Open

class ComputeResource < ApplicationRecord
  audited :except => [:attrs]
  include Taxonomix
  include Encryptable
  include Authorizable

Class HostsController has 83 methods (exceeds 20 allowed). Consider refactoring.

Open

class HostsController < ApplicationController
  include Foreman::Controller::ActionPermissionDsl
  include ScopesPerAction
  include Foreman::Controller::HostDetails
  include Foreman::Controller::AutoCompleteSearch

Class User has 82 methods (exceeds 20 allowed). Consider refactoring.

Open

class User < ApplicationRecord
  audited :except => [:last_login_on, :password_hash, :password_salt, :password_confirmation],
          :associations => [:roles, :usergroups]
  include Authorizable
  include Foreman::TelemetryHelper

Class Ovirt has 79 methods (exceeds 20 allowed). Consider refactoring.

Open

  class Ovirt < ComputeResource
    ALLOWED_DISPLAY_TYPES = %w(vnc spice)

    validates :url, :format => { :with => URI::DEFAULT_PARSER.make_regexp }, :presence => true,
              :url_schema => ['http', 'https']

Class Plugin has 77 methods (exceeds 20 allowed). Consider refactoring.

Open

  class Plugin
    DEFAULT_REGISTRIES = {
      fact_importer: 'Foreman::Plugin::FactImporterRegistry',
      fact_parser: 'Foreman::Plugin::FactParserRegistry',
      report_scanner: 'Foreman::Plugin::ReportScannerRegistry',

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('Should return a selectionController allRowsSelected:false', () => {
    const allRowsSelected = false;
    const selectCtrl = getSelectionController({
      allRowsSelected,
      rows,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('Should return a selectionController allRowsSelected:true', () => {
    const allRowsSelected = true;
    const selectCtrl = getSelectionController({
      allRowsSelected,
      rows,

• Read up
  Read up

File ovirt.rb has 613 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'foreman/exception'
require 'uri'

module Foreman::Model
  class Ovirt < ComputeResource

File user.rb has 613 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'digest/sha1'

class User < ApplicationRecord
  audited :except => [:last_login_on, :password_hash, :password_salt, :password_confirmation],
          :associations => [:roles, :usergroups]

Function HostsIndex has 267 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const HostsIndex = () => {
  const history = useHistory();
  const { location: { search: historySearch } = {} } = history || {};
  const urlParams = new URLSearchParams(historySearch);
  const urlParamsSearch = urlParams.get('search') || '';

Function RegistrationCommandsPage has 264 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const RegistrationCommandsPage = () => {
  const dispatch = useDispatch();

  // Context
  const currentOrganization = useForemanOrganization();

Class Vmware has 71 methods (exceeds 20 allowed). Consider refactoring.

Open

  class Vmware < ComputeResource
    include ComputeResourceConsoleCommon
    include ComputeResourceCaching

    validates :user, :password, :server, :datacenter, :presence => true

File access_permissions.rb has 602 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require_dependency 'foreman/access_control'

# Permissions
Foreman::AccessControl.map do |permission_set|
  permission_set.security_block :public do |map|