theforeman/foreman

View on GitHub
app/assets/javascripts/host_edit_interfaces.js

Summary

Maintainability
C
7 hrs
Test Coverage

File host_edit_interfaces.js has 352 lines of code (exceeds 250 allowed). Consider refactoring.
Open

$(document).ready(function() {
  $('#host_name').select();
  $('#host_name').focus();
});

Severity: Minor
Found in app/assets/javascripts/host_edit_interfaces.js - About 4 hrs to fix

    Function update_interface_row has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function update_interface_row(row, interface_form) {
      var has_errors = interface_form.find('.has-error').length > 0;
      row.toggleClass('has-error', has_errors);
    
      var virtual = interface_form.find('.virtual').is(':checked');
    Severity: Major
    Found in app/assets/javascripts/host_edit_interfaces.js - About 2 hrs to fix

      Function nic_info has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function nic_info(form) {
        var info = '';
        var virtual_types = ['Nic::Bond', 'Nic::Bridge'];
        if (
          form.find('.virtual').is(':checked') ||
      Severity: Minor
      Found in app/assets/javascripts/host_edit_interfaces.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status