theforeman/foreman

View on GitHub
webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js

Summary

Maintainability
D
1 day
Test Coverage

Avoid too many return statements within this function.
Open

      return state.set('isMaximized', !state.isMaximized);
Severity: Major
Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return state.set('isLoading', true);
    Severity: Major
    Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return state.merge(payload);
      Severity: Major
      Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return state.set('isFetchingHosts', false).merge(payload);
        Severity: Major
        Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return state.set('value', payload);
          Severity: Major
          Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return state.set('hosts', payload);
            Severity: Major
            Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return state
                      .set('searchQuery', '')
                      .set('isFetchingHosts', false)
                      .set('isSearchingHosts', false);
              Severity: Major
              Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return state.set('templateKindId', payload);
                Severity: Major
                Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return state.set('diffViewType', payload);
                  Severity: Major
                  Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return state.set('selectedView', payload);
                    Severity: Major
                    Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return state.set('searchQuery', '').set('isSearchingHosts', false);
                      Severity: Major
                      Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return state.merge(payload);
                        Severity: Major
                        Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return state.merge(payload);
                          Severity: Major
                          Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return state.set('isLoading', false);
                            Severity: Major
                            Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return state.set('isMasked', !state.isMasked);
                              Severity: Major
                              Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      return state.set('isRendering', !state.isRendering);
                                Severity: Major
                                Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return state.merge(payload);
                                  Severity: Major
                                  Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                          return state
                                            .set('isSelectOpen', !state.isSelectOpen)
                                            .set('searchQuery', '');
                                    Severity: Major
                                    Found in webpack/assets/javascripts/react_app/components/Editor/EditorReducer.js - About 30 mins to fix

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                      const initialState = Immutable({
                                        [EDITOR_HOST_ARR]: [],
                                        [EDITOR_HOST_FILTERED_ARR]: [],
                                        diffViewType: 'split',
                                        editorName: 'editor',
                                      webpack/assets/javascripts/react_app/common/testHelpers.js on lines 194..225

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 150.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status