Sign upLogin

theforeman/foreman_azure

View on GitHub
Star

Showing 3 of 3 total issues

Function azure_image_selected has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function azure_image_selected() {
  var url = $('#host_compute_attributes_image_id').attr('data-url');
  var imageId = $('#host_compute_attributes_image_id').val();
  var azure_locations = $('#azure_locations');
  var locations_spinner = $('#azure_locations_spinner');
Severity: Minor
Found in app/assets/javascripts/foreman_azure/host_os_azure_selected.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      if (typeof tfm == 'undefined') {  // earlier than 1.13
    foreman.tools.showSpinner();
  } else {
    tfm.tools.showSpinner();
  }
    Severity: Minor
    Found in app/assets/javascripts/foreman_azure/host_os_azure_selected.js and 1 other location - About 35 mins to fix
    app/assets/javascripts/foreman_azure/host_os_azure_selected.js on lines 20..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          if (typeof tfm == 'undefined') {  // earlier than 1.13
        foreman.tools.hideSpinner();
      } else {
        tfm.tools.hideSpinner();
      }
    Severity: Minor
    Found in app/assets/javascripts/foreman_azure/host_os_azure_selected.js and 1 other location - About 35 mins to fix
    app/assets/javascripts/foreman_azure/host_os_azure_selected.js on lines 6..10

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language