theforeman/foreman_fog_proxmox

View on GitHub

Showing 32 of 50 total issues

Class Proxmox has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Proxmox < ComputeResource
    include ProxmoxVmHelper
    include ProxmoxConnection
    include ProxmoxVmNew
    include ProxmoxVmCommands
Severity: Minor
Found in app/models/foreman_fog_proxmox/proxmox.rb - About 2 hrs to fix

    Method setVmDetails has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

          def setVmDetails
            attrs = compute_resource.provided_attributes
            result = true
            attrs.each do |foreman_attr, fog_attr|
              if foreman_attr == :mac
    Severity: Minor
    Found in app/models/concerns/orchestration/proxmox/compute.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_volume has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_volume(vm, disk, volume_attributes)
          id = disk.id
          if volume_type?(volume_attributes, 'cdrom')
            update_cdrom(vm, disk, volume_attributes)
          elsif volume_type?(volume_attributes, 'hard_disk')
    Severity: Minor
    Found in app/models/foreman_fog_proxmox/proxmox_volumes.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_server_cloudinit has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def parse_server_cloudinit(args)
        cloudinit_h = {}
        cloudinit = args['cloudinit']
        unless ['none'].include? cloudinit
          volid = args['volid']
    Severity: Minor
    Found in app/helpers/proxmox_vm_cloudinit_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_vm has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def create_vm(args = {})
          vmid = args[:vmid].to_i
          type = args[:type]
          node = client.nodes.get(args[:node_id])
          vmid = node.servers.next_id.to_i if vmid < 1
    Severity: Minor
    Found in app/models/foreman_fog_proxmox/proxmox_vm_commands.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateOptions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function updateOptions(options_path, start_options_id, end_options_id, start_second_options_id, end_second_options_id, option_id, node_id, second_id) {
      
      var select_ids = selectIds(start_options_id, end_options_id);
      var select_second_ids;
      if ( start_second_options_id != undefined && end_second_options_id != undefined) {
    Severity: Minor
    Found in app/assets/javascripts/foreman_fog_proxmox/proxmox_vm.js - About 1 hr to fix

      Method host_interfaces_attrs has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def host_interfaces_attrs(host)
            host.interfaces.select(&:physical?).each.with_index.reduce({}) do |hash, (nic, index)|
              set_nic_identifier(nic, index)
              set_container_interface_name(host, nic, index) if container?(host)
              ForemanFogProxmox::HashCollection.remove_empty_values(nic.compute_attributes)
      Severity: Minor
      Found in app/models/foreman_fog_proxmox/proxmox_interfaces.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method proxmox_cpus_map has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def proxmox_cpus_map
          [OpenStruct.new(id: '486', name: '486'),
           OpenStruct.new(id: 'athlon', name: 'athlon'),
           OpenStruct.new(id: 'core2duo', name: 'core2duo'),
           OpenStruct.new(id: 'coreduo', name: 'coreduo'),
      Severity: Minor
      Found in app/helpers/proxmox_compute_selectors_helper.rb - About 1 hr to fix

        Method password_proxmox_f has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def password_proxmox_f(f, attr, options = {})
            unset_button = options.delete(:unset)
            value = f.object[attr] if options.delete(:keep_value)
            password_field_tag(:fakepassword, value, :style => 'display: none', :autocomplete => 'new-password-fake') +
              field(f, attr, options) do
        Severity: Minor
        Found in app/helpers/proxmox_form_helper.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateOptions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function updateOptions(options_path, start_options_id, end_options_id, start_second_options_id, end_second_options_id, option_id, node_id, second_id) {
          
          var select_ids = selectIds(start_options_id, end_options_id);
          var select_second_ids;
          if ( start_second_options_id != undefined && end_second_options_id != undefined) {
        Severity: Minor
        Found in app/assets/javascripts/foreman_fog_proxmox/proxmox_vm.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method new_typed_vm has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def new_typed_vm(new_attr, type)
              convert_config_attributes(new_attr) if new_attr.key?(:config_attributes)
              node_id = new_attr['node_id']
              node = node_id ? client.nodes.get(node_id) : default_node
              new_attr_type = new_attr['type']
        Severity: Minor
        Found in app/models/foreman_fog_proxmox/proxmox_vm_new.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add_or_delete_typed_interface has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def add_or_delete_typed_interface(interface_attributes, interfaces_to_delete, interfaces_to_add, type)
            logger.debug("add_or_delete_typed_interface(#{type}): interface_attributes=#{interface_attributes}")
            ForemanFogProxmox::HashCollection.remove_empty_values(interface_attributes)
            if interface_attributes['compute_attributes']
              ForemanFogProxmox::HashCollection.remove_empty_values(interface_attributes['compute_attributes'])
        Severity: Minor
        Found in app/helpers/proxmox_vm_interfaces_helper.rb - About 1 hr to fix

          Function updateOptions has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function updateOptions(options_path, start_options_id, end_options_id, start_second_options_id, end_second_options_id, option_id, node_id, second_id) {
          Severity: Major
          Found in app/assets/javascripts/foreman_fog_proxmox/proxmox_vm.js - About 1 hr to fix

            Method parse_hard_disk_volume has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def parse_hard_disk_volume(args)
                logger.debug(format(_('parse_hard_disk_volume(): args=%<args>s'), args: args))
                disk = {}
                disk[:id] = args['id'] if args.key?('id')
                disk[:volid] = args['volid'] if args.key?('volid')
            Severity: Minor
            Found in app/helpers/proxmox_vm_volumes_helper.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method save_vm has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def save_vm(uuid, new_attributes)
                  vm = find_vm_by_uuid(uuid)
                  templated = new_attributes['templated']
                  node_id = new_attributes['node_id']
                  if templated == '1' && !vm.templated?
            Severity: Minor
            Found in app/models/foreman_fog_proxmox/proxmox_vm_commands.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method save_volume has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def save_volume(vm, volume_attributes)
                  logger.debug("save_volume(#{vm.identity}) volume_attributes=#{volume_attributes}")
                  id = extract_id(vm, volume_attributes)
                  if volume_exists?(vm, volume_attributes)
                    if volume_to_delete?(volume_attributes)
            Severity: Minor
            Found in app/models/foreman_fog_proxmox/proxmox_volumes.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method version has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def version
                  v = identity_client.read_version if identity_client
                  v ? v['version'] : 'Unknown'
                rescue ::Foreman::Exception => e
                  return 'Unkown' if e.message == 'User token expired'
            Severity: Minor
            Found in app/models/foreman_fog_proxmox/proxmox_version.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method volume_type? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def volume_type?(args, type)
                if args.key?('storage_type')
                  args['storage_type'] == type
                else
                  Fog::Proxmox::DiskHelper.cloud_init?(args['volid']) if type == 'cloud_init'
            Severity: Minor
            Found in app/helpers/proxmox_vm_volumes_helper.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method extract_id has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def extract_id(vm, volume_attributes)
                  id = ''
                  if volume_exists?(vm, volume_attributes)
                    id = volume_attributes['id']
                  else
            Severity: Minor
            Found in app/models/foreman_fog_proxmox/proxmox_volumes.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method add_and_format_element has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def self.add_and_format_element(dest, dest_key, origin, origin_key, format = :to_s)
            Severity: Minor
            Found in lib/foreman_fog_proxmox/hash_collection.rb - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language