Sign upLogin

theforeman/foreman_fog_proxmox

View on GitHub
Star
webpack/components/ProxmoxContainer/MountPoint.js

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      <InputField
        name={mp?.storage?.name}
        label={__('Storage')}
        type="select"
        options={storagesMap}
Severity: Major
Found in webpack/components/ProxmoxContainer/MountPoint.js and 2 other locations - About 1 hr to fix
webpack/components/ProxmoxContainer/components/NetworkInterface.js on lines 98..105
webpack/components/ProxmoxServer/components/NetworkInterface.js on lines 84..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

      <InputField
        name={mp?.size?.name}
        label={__('Size (GB)')}
        type="number"
        value={mp?.size?.value}
Severity: Major
Found in webpack/components/ProxmoxContainer/MountPoint.js and 23 other locations - About 1 hr to fix
webpack/components/GeneralTabContent.js on lines 77..83
webpack/components/ProxmoxContainer/ProxmoxContainerHardware.js on lines 33..39
webpack/components/ProxmoxContainer/ProxmoxContainerHardware.js on lines 40..46
webpack/components/ProxmoxContainer/ProxmoxContainerHardware.js on lines 47..53
webpack/components/ProxmoxContainer/ProxmoxContainerHardware.js on lines 58..64
webpack/components/ProxmoxContainer/ProxmoxContainerHardware.js on lines 65..71
webpack/components/ProxmoxContainer/ProxmoxContainerStorage.js on lines 125..131
webpack/components/ProxmoxContainer/components/NetworkInterface.js on lines 122..128
webpack/components/ProxmoxContainer/components/NetworkInterface.js on lines 145..151
webpack/components/ProxmoxContainer/components/NetworkInterface.js on lines 152..158
webpack/components/ProxmoxContainer/components/NetworkInterface.js on lines 159..165
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 104..110
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 111..117
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 118..124
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 125..131
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 132..138
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 170..176
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 177..183
webpack/components/ProxmoxServer/ProxmoxServerHardware.js on lines 184..190
webpack/components/ProxmoxServer/components/HardDisk.js on lines 121..127
webpack/components/ProxmoxServer/components/NetworkInterface.js on lines 92..98
webpack/components/ProxmoxServer/components/NetworkInterface.js on lines 99..105
webpack/components/ProxmoxServer/components/NetworkInterface.js on lines 106..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      <input
        name={mp?.volid?.name}
        type="hidden"
        value={mp?.volid?.value}
        onChange={handleChange}
Severity: Major
Found in webpack/components/ProxmoxContainer/MountPoint.js and 4 other locations - About 40 mins to fix
webpack/components/ProxmoxContainer/MountPoint.js on lines 61..66
webpack/components/ProxmoxServer/components/HardDisk.js on lines 70..75
webpack/components/ProxmoxServer/components/HardDisk.js on lines 76..81
webpack/components/ProxmoxServer/components/HardDisk.js on lines 82..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

      <input
        name={mp?.id?.name}
        type="hidden"
        value={mp?.id?.value}
        onChange={handleChange}
Severity: Major
Found in webpack/components/ProxmoxContainer/MountPoint.js and 4 other locations - About 40 mins to fix
webpack/components/ProxmoxContainer/MountPoint.js on lines 67..72
webpack/components/ProxmoxServer/components/HardDisk.js on lines 70..75
webpack/components/ProxmoxServer/components/HardDisk.js on lines 76..81
webpack/components/ProxmoxServer/components/HardDisk.js on lines 82..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status