Sign upLogin

themattrix/bashup

View on GitHub
Star

Showing 15 of 15 total issues

File test_parse.py has 383 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import string

import itertools
import pyparsing as pp
import pytest
Severity: Minor
Found in bashup/test/test_parse.py - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        ('@fn h a1=v1,a2,a3=v3,a4{',
     parse.FnSpec(
         name='h',
         args=(parse.FnArgSpec(name='a1', value='v1'),
               parse.FnArgSpec(name='a2', value=None),
    Severity: Major
    Found in bashup/test/test_parse.py and 1 other location - About 3 hrs to fix
    bashup/test/test_parse.py on lines 45..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        ('@fn h a1=v1, a2, a3=v3, a4 {',
     parse.FnSpec(
         name='h',
         args=(parse.FnArgSpec(name='a1', value='v1'),
               parse.FnArgSpec(name='a2', value=None),
    Severity: Major
    Found in bashup/test/test_parse.py and 1 other location - About 3 hrs to fix
    bashup/test/test_parse.py on lines 52..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File test_elements.py has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import textwrap

from ...compile import elements
from ... import parse
from ... import test
    Severity: Minor
    Found in bashup/test/test_compile/test_elements.py - About 2 hrs to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          ('''@fn h a="'", b="'" {''',
     parse.FnSpec(
         name='h',
         args=(parse.FnArgSpec(name='a', value='"\'"'),
               parse.FnArgSpec(name='b', value='"\'"')))),
      Severity: Major
      Found in bashup/test/test_parse.py and 4 other locations - About 1 hr to fix
      bashup/test/test_parse.py on lines 40..44
      bashup/test/test_parse.py on lines 65..69
      bashup/test/test_parse.py on lines 70..74
      bashup/test/test_parse.py on lines 80..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          ('''@fn h a='"', b='"' {''',
     parse.FnSpec(
         name='h',
         args=(parse.FnArgSpec(name='a', value="'\"'"),
               parse.FnArgSpec(name='b', value="'\"'")))),
      Severity: Major
      Found in bashup/test/test_parse.py and 4 other locations - About 1 hr to fix
      bashup/test/test_parse.py on lines 40..44
      bashup/test/test_parse.py on lines 65..69
      bashup/test/test_parse.py on lines 75..79
      bashup/test/test_parse.py on lines 80..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          ('@fn hello arg1=value1, arg2=value2 {',
     parse.FnSpec(
         name='hello',
         args=(parse.FnArgSpec(name='arg1', value='value1'),
               parse.FnArgSpec(name='arg2', value='value2')))),
      Severity: Major
      Found in bashup/test/test_parse.py and 4 other locations - About 1 hr to fix
      bashup/test/test_parse.py on lines 65..69
      bashup/test/test_parse.py on lines 70..74
      bashup/test/test_parse.py on lines 75..79
      bashup/test/test_parse.py on lines 80..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          ('''@fn h a="${PATH//"/bin"/"/bun"}", b="\\"" {''',
     parse.FnSpec(
         name='h',
         args=(parse.FnArgSpec(name='a', value='"${PATH//"/bin"/"/bun"}"'),
               parse.FnArgSpec(name='b', value='"\\""')))),
      Severity: Major
      Found in bashup/test/test_parse.py and 4 other locations - About 1 hr to fix
      bashup/test/test_parse.py on lines 40..44
      bashup/test/test_parse.py on lines 65..69
      bashup/test/test_parse.py on lines 70..74
      bashup/test/test_parse.py on lines 75..79

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          ('''@fn h a="", b='' {''',
     parse.FnSpec(
         name='h',
         args=(parse.FnArgSpec(name='a', value='""'),
               parse.FnArgSpec(name='b', value="''")))),
      Severity: Major
      Found in bashup/test/test_parse.py and 4 other locations - About 1 hr to fix
      bashup/test/test_parse.py on lines 40..44
      bashup/test/test_parse.py on lines 70..74
      bashup/test/test_parse.py on lines 75..79
      bashup/test/test_parse.py on lines 80..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function __assert_compiled_bash has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def __assert_compiled_bash(
      Severity: Minor
      Found in bashup/test/test_bashup.py - About 35 mins to fix

        Function run_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def run_file(to_run, args, compile_fn=bash.compile_to_bash, run_fn=subprocess.call, temp_file_ctx=temporary.temp_file):
        Severity: Minor
        Found in bashup/__main__.py - About 35 mins to fix

          TODO found
          Open

          .. _this document for planned features: TODO.rst
          Severity: Minor
          Found in README.rst by fixme

          XXX found
          Open

          notes=FIXME,XXX,TODO
          Severity: Minor
          Found in .pylintrc by fixme

          TODO found
          Open

          notes=FIXME,XXX,TODO
          Severity: Minor
          Found in .pylintrc by fixme

          FIXME found
          Open

          notes=FIXME,XXX,TODO
          Severity: Minor
          Found in .pylintrc by fixme
          Severity
          Category
          Status
          Source
          Language