themichaelhall/datatypes

View on GitHub

Showing 36 of 40 total issues

File Url.php has 352 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is a part of the datatypes package.
 *
Severity: Minor
Found in src/Net/Url.php - About 4 hrs to fix

    Url has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Url implements UrlInterface
    {
        /**
         * Returns true if the url equals other url, false otherwise.
         *
    Severity: Minor
    Found in src/Net/Url.php - About 4 hrs to fix

      FilePath has 29 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class FilePath implements FilePathInterface
      {
          /**
           * Returns true if the file path equals other file path, false otherwise.
           *
      Severity: Minor
      Found in src/System/FilePath.php - About 3 hrs to fix

        UrlPath has 26 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class UrlPath implements UrlPathInterface
        {
            /**
             * Returns true if the url path equals other url path, false otherwise.
             *
        Severity: Minor
        Found in src/Net/UrlPath.php - About 3 hrs to fix

          File FilePath.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          /**
           * This file is a part of the datatypes package.
           *
          Severity: Minor
          Found in src/System/FilePath.php - About 2 hrs to fix

            Function normalizeDirectoryParts has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function normalizeDirectoryParts(bool $isAbsolute, array &$parts, int &$aboveBaseLevel, ?string &$error = null): bool
                {
                    $newParts = [];
            
                    foreach ($parts as $part) {
            Severity: Minor
            Found in src/System/FilePath.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function normalizeDirectoryParts has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function normalizeDirectoryParts(bool $isAbsolute, array &$parts, int &$aboveBaseLevel, ?string &$error = null): bool
                {
                    $newParts = [];
            
                    foreach ($parts as $part) {
            Severity: Minor
            Found in src/Net/UrlPath.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function parseParts has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function parseParts(array $parts, bool $parseAsDirectory, bool &$isAbsolute, array &$directoryParts, ?string &$filename, ?string &$error): bool
                {
                    $isAbsolute = count($parts) > 1 && $parts[0] === '';
                    if ($isAbsolute) {
                        array_shift($parts);
            Severity: Minor
            Found in src/Net/UrlPath.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function parseParts has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function parseParts(array $parts, bool $parseAsDirectory, bool &$isAbsolute, array &$directoryParts, ?string &$filename, ?string &$error): bool
                {
                    $isAbsolute = count($parts) > 1 && $parts[0] === '';
                    if ($isAbsolute) {
                        array_shift($parts);
            Severity: Minor
            Found in src/System/FilePath.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method doParse has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private static function doParse(string $str, bool $parseAsDirectory, ?string &$error = null): ?self
                {
                    $drive = null;
            
                    // If on Window, try to parse drive.
            Severity: Minor
            Found in src/System/FilePath.php - About 1 hr to fix

              Function doParse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  private static function doParse(string $str, bool $parseAsDirectory, ?string &$error = null): ?self
                  {
                      $drive = null;
              
                      // If on Window, try to parse drive.
              Severity: Minor
              Found in src/System/FilePath.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method doParse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private static function doParse(?UrlInterface $baseUrl, string $str, ?string &$error = null): ?self
                  {
                      if ($baseUrl === null && $str === '') {
                          $error = 'Url "" is empty.';
              
              
              Severity: Minor
              Found in src/Net/Url.php - About 1 hr to fix

                Method doParse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private static function doParse(string $str, ?string &$error = null): ?self
                    {
                        if ($str === '') {
                            $error = 'Hostname "' . $str . '" is empty.';
                
                
                Severity: Minor
                Found in src/Net/Hostname.php - About 1 hr to fix

                  Method parsePath has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private static function parsePath(string $pathString, ?UrlPathInterface &$path, ?string &$queryString, ?string &$fragment, ?string &$error = null): bool
                      {
                          $oldFragment = $fragment;
                  
                          $parts = explode('#', $pathString, 2);
                  Severity: Minor
                  Found in src/Net/Url.php - About 1 hr to fix

                    Method parseAuthority has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private static function parseAuthority(?string $authorityString, ?HostInterface &$host, ?int &$port, ?string &$error = null): bool
                        {
                            if ($authorityString === null && $host !== null) {
                                return true;
                            }
                    Severity: Minor
                    Found in src/Net/Url.php - About 1 hr to fix

                      Function parsePath has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private static function parsePath(string $pathString, ?UrlPathInterface &$path, ?string &$queryString, ?string &$fragment, ?string &$error = null): bool
                          {
                              $oldFragment = $fragment;
                      
                              $parts = explode('#', $pathString, 2);
                      Severity: Minor
                      Found in src/Net/Url.php - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function parseAuthority has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private static function parseAuthority(?string $authorityString, ?HostInterface &$host, ?int &$port, ?string &$error = null): bool
                          {
                              if ($authorityString === null && $host !== null) {
                                  return true;
                              }
                      Severity: Minor
                      Found in src/Net/Url.php - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method fromParts has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public static function fromParts(SchemeInterface $scheme, HostInterface $host, ?int $port = null, UrlPathInterface $path = null, ?string $queryString = null, ?string $fragment = null): UrlInterface
                      Severity: Minor
                      Found in src/Net/Url.php - About 45 mins to fix

                        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            private function __construct(SchemeInterface $scheme, HostInterface $host, int $port, UrlPathInterface $path, ?string $queryString, ?string $fragment)
                        Severity: Minor
                        Found in src/Net/Url.php - About 45 mins to fix

                          Method parseParts has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              private static function parseParts(array $parts, bool $parseAsDirectory, bool &$isAbsolute, array &$directoryParts, ?string &$filename, ?string &$error): bool
                          Severity: Minor
                          Found in src/Net/UrlPath.php - About 45 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language