themichaelhall/datatypes

File `Url.php` has 352 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is a part of the datatypes package.
 *

Found in src/Net/Url.php - About 4 hrs to fix

`Url` has 34 functions (exceeds 20 allowed). Consider refactoring.
Open

class Url implements UrlInterface
{
    /**
     * Returns true if the url equals other url, false otherwise.
     *

Found in src/Net/Url.php - About 4 hrs to fix

`FilePath` has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class FilePath implements FilePathInterface
{
    /**
     * Returns true if the file path equals other file path, false otherwise.
     *

Found in src/System/FilePath.php - About 3 hrs to fix

`UrlPath` has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class UrlPath implements UrlPathInterface
{
    /**
     * Returns true if the url path equals other url path, false otherwise.
     *

Found in src/Net/UrlPath.php - About 3 hrs to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private static function normalizeDirectoryParts(bool $isAbsolute, array &$parts, int &$aboveBaseLevel, ?string &$error = null): bool
    {
        $newParts = [];

        foreach ($parts as $part) {

Found in src/System/FilePath.php and 1 other location - About 2 hrs to fix

Read up
Read up

src/Net/UrlPath.php on lines 463..496

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private static function normalizeDirectoryParts(bool $isAbsolute, array &$parts, int &$aboveBaseLevel, ?string &$error = null): bool
    {
        $newParts = [];

        foreach ($parts as $part) {

Found in src/Net/UrlPath.php and 1 other location - About 2 hrs to fix

Read up
Read up

src/System/FilePath.php on lines 502..535

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

File `FilePath.php` has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is a part of the datatypes package.
 *

Found in src/System/FilePath.php - About 2 hrs to fix

Function `normalizeDirectoryParts` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private static function normalizeDirectoryParts(bool $isAbsolute, array &$parts, int &$aboveBaseLevel, ?string &$error = null): bool
    {
        $newParts = [];

        foreach ($parts as $part) {

Found in src/System/FilePath.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `normalizeDirectoryParts` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private static function normalizeDirectoryParts(bool $isAbsolute, array &$parts, int &$aboveBaseLevel, ?string &$error = null): bool
    {
        $newParts = [];

        foreach ($parts as $part) {

Found in src/Net/UrlPath.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `parseParts` has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private static function parseParts(array $parts, bool $parseAsDirectory, bool &$isAbsolute, array &$directoryParts, ?string &$filename, ?string &$error): bool
    {
        $isAbsolute = count($parts) > 1 && $parts[0] === '';
        if ($isAbsolute) {
            array_shift($parts);

Found in src/Net/UrlPath.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `parseParts` has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private static function parseParts(array $parts, bool $parseAsDirectory, bool &$isAbsolute, array &$directoryParts, ?string &$filename, ?string &$error): bool
    {
        $isAbsolute = count($parts) > 1 && $parts[0] === '';
        if ($isAbsolute) {
            array_shift($parts);

Found in src/System/FilePath.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `doParse` has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function doParse(string $str, bool $parseAsDirectory, ?string &$error = null): ?self
    {
        $drive = null;

        // If on Window, try to parse drive.

Found in src/System/FilePath.php - About 1 hr to fix

Function `doParse` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private static function doParse(string $str, bool $parseAsDirectory, ?string &$error = null): ?self
    {
        $drive = null;

        // If on Window, try to parse drive.

Found in src/System/FilePath.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `doParse` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function doParse(?UrlInterface $baseUrl, string $str, ?string &$error = null): ?self
    {
        if ($baseUrl === null && $str === '') {
            $error = 'Url "" is empty.';

Found in src/Net/Url.php - About 1 hr to fix

Method `doParse` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function doParse(string $str, ?string &$error = null): ?self
    {
        if ($str === '') {
            $error = 'Hostname "' . $str . '" is empty.';

Found in src/Net/Hostname.php - About 1 hr to fix

Method `parsePath` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function parsePath(string $pathString, ?UrlPathInterface &$path, ?string &$queryString, ?string &$fragment, ?string &$error = null): bool
    {
        $oldFragment = $fragment;

        $parts = explode('#', $pathString, 2);

Found in src/Net/Url.php - About 1 hr to fix

Method `parseAuthority` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function parseAuthority(?string $authorityString, ?HostInterface &$host, ?int &$port, ?string &$error = null): bool
    {
        if ($authorityString === null && $host !== null) {
            return true;
        }

Found in src/Net/Url.php - About 1 hr to fix

Function `parsePath` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private static function parsePath(string $pathString, ?UrlPathInterface &$path, ?string &$queryString, ?string &$fragment, ?string &$error = null): bool
    {
        $oldFragment = $fragment;

        $parts = explode('#', $pathString, 2);

Found in src/Net/Url.php - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `parseAuthority` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private static function parseAuthority(?string $authorityString, ?HostInterface &$host, ?int &$port, ?string &$error = null): bool
    {
        if ($authorityString === null && $host !== null) {
            return true;
        }

Found in src/Net/Url.php - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `fromParts` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static function fromParts(SchemeInterface $scheme, HostInterface $host, ?int $port = null, UrlPathInterface $path = null, ?string $queryString = null, ?string $fragment = null): UrlInterface

Found in src/Net/Url.php - About 45 mins to fix