Sign upLogin

themouette/fossil-core

View on GitHub
Star

Showing 86 of 86 total issues

Function load has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    req.load = function (context, moduleName, url) {
        var config = (context && context.config) || {},
            node;
        if (isBrowser) {
            //In the browser so use a script tag
Severity: Minor
Found in samples/todo/app.js - About 1 hr to fix

    Function localRequire has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                    function localRequire(deps, callback, errback) {
                    var id, map, requireMod;

                    if (options.enableBuildCallback && callback && isFunction(callback)) {
                        callback.__requireJsBuild = true;
    Severity: Minor
    Found in samples/todo/app.js - About 1 hr to fix

      Function services_session has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var services_session = function (_, Backbone, utils, Service) {
        
        var expose = [
                'get',
                'set',
      Severity: Minor
      Found in samples/fossil-core.js - About 1 hr to fix

        Function nameToUrl has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    nameToUrl: function (moduleName, ext, skipExt) {
                var paths, pkgs, pkg, pkgPath, syms, i, parentModule, url,
                    parentPath;

                //If a colon is in the URL, it indicates a protocol is used and it is just
        Severity: Minor
        Found in samples/todo/app.js - About 1 hr to fix

          Function services_session has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var services_session = function (_, Backbone, utils, Service) {
        
        var expose = [
                'get',
                'set',
          Severity: Minor
          Found in fossil-core.js - About 1 hr to fix

            Function completeLoad has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        completeLoad: function (moduleName) {
                var found, args, mod,
                    shim = getOwn(config.shim, moduleName) || {},
                    shExports = shim.exports;
            Severity: Minor
            Found in samples/todo/app.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      _doStandby: function () {
            Startable._doStandby.apply(this, arguments);
            _.each(this.modules, function (module) {
                module.standby();
            }, this);
              Severity: Major
              Found in src/module.js and 1 other location - About 1 hr to fix
              src/module.js on lines 352..357

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      _doStop: function () {
            Startable._doStop.apply(this, arguments);
            _.each(this.modules, function (module) {
                module.stop();
            }, this);
              Severity: Major
              Found in src/module.js and 1 other location - About 1 hr to fix
              src/module.js on lines 344..349

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function fromText has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                                  load.fromText = bind(this, function (text, textAlt) {
                        /*jslint evil: true */
                        var moduleName = map.name,
                            moduleMap = makeModuleMap(moduleName),
                            hasInteractive = useInteractive;
              Severity: Minor
              Found in samples/todo/app.js - About 1 hr to fix

                Function route has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                                route: function (module, path, name, callback) {
                    var original;
                    path = url(module.url, path);
                    if (typeof name === 'function' || !callback) {
                        callback = name;
                Severity: Minor
                Found in samples/fossil-core.js - About 1 hr to fix

                  Function route has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                                  route: function (module, path, name, callback) {
                    var original;
                    path = url(module.url, path);
                    if (typeof name === 'function' || !callback) {
                        callback = name;
                  Severity: Minor
                  Found in fossil-core.js - About 1 hr to fix

                    Function route has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            route: function (module, path, name, callback) {
            var original;
            path = url(module.url, path);
            if (typeof(name) === "function" || !callback) {
                callback = name;
                    Severity: Minor
                    Found in src/services/routing.js - About 1 hr to fix

                      Function engines_handlebars has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      var engines_handlebars = function (_, Backbone, Handlebars, Mixin, Observable, Deferrable, Startable) {
                      Severity: Major
                      Found in samples/fossil-core.js - About 50 mins to fix

                        Function engines_handlebars has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        var engines_handlebars = function (_, Backbone, Handlebars, Mixin, Observable, Deferrable, Startable) {
                        Severity: Major
                        Found in fossil-core.js - About 50 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  onAlways: function (promise) {
            if (!this.isValidPromise(promise)) {return ;}
            this.processAsyncReturn(promise, _.rest(arguments, 1));
        },
                          Severity: Minor
                          Found in src/mixins/deferrable.js and 1 other location - About 50 mins to fix
                          src/mixins/deferrable.js on lines 149..152

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 52.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  onDone: function (promise) {
            if (!this.isValidPromise(promise)) {return ;}
            this.processAsyncReturn(promise, _.rest(arguments, 1));
        },
                          Severity: Minor
                          Found in src/mixins/deferrable.js and 1 other location - About 50 mins to fix
                          src/mixins/deferrable.js on lines 159..162

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 52.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Avoid deeply nested control flow statements.
                          Open

                                                      if (mapValue) {
                                mapValue = getOwn(mapValue, nameSegment);
                                if (mapValue) {
                                    //Match, update name to the new value.
                                    foundMap = mapValue;
                          Severity: Major
                          Found in samples/todo/app.js - About 45 mins to fix

                            Function engines_underscore has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            var engines_underscore = function (_, Backbone, Mixin, Observable, Deferrable, Startable) {
                            Severity: Minor
                            Found in fossil-core.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                          if (moduleName === pkg.name) {
                                pkgPath = pkg.location + '/' + pkg.main;
                            } else {
                                pkgPath = pkg.location;
                            }
                              Severity: Major
                              Found in samples/todo/app.js - About 45 mins to fix

                                Function engines_underscore has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                var engines_underscore = function (_, Backbone, Mixin, Observable, Deferrable, Startable) {
                                Severity: Minor
                                Found in samples/fossil-core.js - About 45 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language