Sign upLogin

thenetcircle/dino

View on GitHub
Star
dino/db/manager/users.py

Summary

Maintainability
D
1 day
Test Coverage

File users.py has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import logging
import traceback
from datetime import datetime
from typing import Optional
from uuid import uuid4 as uuid
Severity: Minor
Found in dino/db/manager/users.py - About 4 hrs to fix

    UserManager has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class UserManager(BaseManager):
    def __init__(self, env: GNEnvironment):
        self.env = env

    def auth_user(self, user_id, _):
    Severity: Minor
    Found in dino/db/manager/users.py - About 3 hrs to fix

      Cyclomatic complexity is too high in method ban_user. (10)
      Open

          def ban_user(
            self, user_id: str, target_id: str, duration: str, target_type: str,
            reason: str = None, banner_id: str = None, user_name: str = None, target_name: str = None
    ) -> None:
        if target_type not in {'global', 'channel', 'room'}:
      Severity: Minor
      Found in dino/db/manager/users.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method kick_user. (8)
      Open

          def kick_user(
            self, room_id: Optional[str], user_id: str, reason: str = None, admin_id: str = None, room_name: str = None
    ) -> None:
        # TODO: support get room_id from room name
      Severity: Minor
      Found in dino/db/manager/users.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function kick_user has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def kick_user(
            self, room_id: Optional[str], user_id: str, reason: str = None, admin_id: str = None, room_name: str = None
    ) -> None:
        # TODO: support get room_id from room name
      Severity: Minor
      Found in dino/db/manager/users.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ban_user has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def ban_user(
            self, user_id: str, target_id: str, duration: str, target_type: str,
            reason: str = None, banner_id: str = None, user_name: str = None, target_name: str = None
    ) -> None:
        if target_type not in {'global', 'channel', 'room'}:
      Severity: Minor
      Found in dino/db/manager/users.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ban_user has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def ban_user(
      Severity: Major
      Found in dino/db/manager/users.py - About 1 hr to fix

        Function mute_user has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def mute_user(
        Severity: Minor
        Found in dino/db/manager/users.py - About 45 mins to fix

          Function room_created has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def room_created(self, user_id, user_name, room_id, room_name, session_ids, namespace) -> None:
          Severity: Minor
          Found in dino/db/manager/users.py - About 45 mins to fix

            Function created_activity has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def created_activity(user_id: str, user_name: str, target_id: str, target_name: str, session_ids: list, namespace: str) -> dict:
            Severity: Minor
            Found in dino/db/manager/users.py - About 45 mins to fix

              Function join_room has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def join_room(self, user_id, user_name, room_id, session_ids, namespace) -> None:
              Severity: Minor
              Found in dino/db/manager/users.py - About 35 mins to fix

                Function leave_room has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def leave_room(self, user_id, user_name, room_id, session_ids, namespace) -> None:
                Severity: Minor
                Found in dino/db/manager/users.py - About 35 mins to fix

                  Function kick_user has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def kick_user(
                  Severity: Minor
                  Found in dino/db/manager/users.py - About 35 mins to fix

                    Function join_activity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def join_activity(user_id: str, user_name: str, target_id: str, session_ids: list, namespace: str) -> dict:
                    Severity: Minor
                    Found in dino/db/manager/users.py - About 35 mins to fix

                      Function leave_activity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def leave_activity(user_id: str, user_name: str, target_id: str, session_ids: list, namespace: str) -> dict:
                      Severity: Minor
                      Found in dino/db/manager/users.py - About 35 mins to fix

                        TODO found
                        Open

                                # TODO: support get room_id from room name
                        Severity: Minor
                        Found in dino/db/manager/users.py by fixme

                        There are no issues that match your filters.

                        Category
                        Status