thenetcircle/dino

View on GitHub

Showing 809 of 809 total issues

Avoid too many return statements within this function.
Open

            return {
Severity: Major
Found in dino/rest/resources/muted.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return True, None  # 'no acl set that allows action "%s" for target type "%s"' % (action, target)
    Severity: Major
    Found in dino/validation/acl.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return False, 'value too high'
      Severity: Major
      Found in dino/validation/acl.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return False, 'channels are not the same'
        Severity: Major
        Found in dino/validation/acl.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return True, None
          Severity: Major
          Found in dino/validation/acl.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return True, None, None
            Severity: Major
            Found in dino/validation/request.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return False, ECodes.USER_IS_BANNED, json_act
              Severity: Major
              Found in dino/validation/request.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return False, ECodes.ROOM_NAME_RESTRICTED, 'restricted room name'
                Severity: Major
                Found in dino/validation/request.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return True, None, None
                  Severity: Major
                  Found in dino/validation/request.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return False, ECodes.NOT_ALLOWED, msg
                    Severity: Major
                    Found in dino/validation/request.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return False, ECodes.NO_SUCH_CHANNEL, 'channel does not exist'
                      Severity: Major
                      Found in dino/validation/request.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return False
                        Severity: Major
                        Found in dino/endpoint/queue.py - About 30 mins to fix

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                  if username is not None and username != '':
                                      params['username'] = username
                          Severity: Major
                          Found in dino/db/rdbms/dbman.py and 4 other locations - About 30 mins to fix
                          dino/db/rdbms/dbman.py on lines 59..60
                          dino/db/rdbms/dbman.py on lines 61..62
                          dino/db/rdbms/dbman.py on lines 65..66
                          dino/db/rdbms/dbman.py on lines 67..68

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 32.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Avoid too many return statements within this function.
                          Open

                                      return False
                          Severity: Major
                          Found in dino/endpoint/queue.py - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                            if room_id is not None and not len(room_id.strip()):
                                                room_id = None
                            Severity: Minor
                            Found in dino/rest/resources/kick.py and 1 other location - About 30 mins to fix
                            dino/rest/resources/kick.py on lines 56..57

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                    if password is not None and password != '':
                                        params['password'] = password
                            Severity: Major
                            Found in dino/db/rdbms/dbman.py and 4 other locations - About 30 mins to fix
                            dino/db/rdbms/dbman.py on lines 59..60
                            dino/db/rdbms/dbman.py on lines 61..62
                            dino/db/rdbms/dbman.py on lines 63..64
                            dino/db/rdbms/dbman.py on lines 67..68

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                    if host is not None and host != '':
                                        params['host'] = host
                            Severity: Major
                            Found in dino/db/rdbms/dbman.py and 4 other locations - About 30 mins to fix
                            dino/db/rdbms/dbman.py on lines 61..62
                            dino/db/rdbms/dbman.py on lines 63..64
                            dino/db/rdbms/dbman.py on lines 65..66
                            dino/db/rdbms/dbman.py on lines 67..68

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                    if port is not None and port != '':
                                        params['port'] = port
                            Severity: Major
                            Found in dino/db/rdbms/dbman.py and 4 other locations - About 30 mins to fix
                            dino/db/rdbms/dbman.py on lines 59..60
                            dino/db/rdbms/dbman.py on lines 63..64
                            dino/db/rdbms/dbman.py on lines 65..66
                            dino/db/rdbms/dbman.py on lines 67..68

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            api_room_actions = [(a, a.upper()) for a in acl_config[ApiTargets.ROOM].keys()]
                            Severity: Minor
                            Found in dino/admin/forms/__init__.py and 1 other location - About 30 mins to fix
                            dino/admin/forms/__init__.py on lines 26..26

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                            if room_name is not None and not len(room_name.strip()):
                                                room_name = None
                            Severity: Minor
                            Found in dino/rest/resources/kick.py and 1 other location - About 30 mins to fix
                            dino/rest/resources/kick.py on lines 54..55

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language