lib/chargify/cash_report.rb
Method refund_row
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def refund_row(refund)
customer = @customers[refund.customer_id]
product = @products[refund.product_id]
refund_transactions = Chargify::Transaction.all(from: "/subscriptions/#{refund.subscription_id}/transactions").group_by(&:type)
payment = refund_transactions['Payment'].first
Method transactions_for_subscription
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
def transactions_for_subscription(subscription_id)
subscription_transactions = transactions[subscription_id]
subscription_transactions.each do |transaction|
next unless transaction.type == "Charge"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method data
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def data
table = []
table << headers_row
transactions.keys.sort.each do |subscription_id|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"