there4/slim-test-helpers

View on GitHub
src/There4/Slim/Test/NoCacheRouter.php

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

The method getMatchedRoutes has a boolean flag argument $reload, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getMatchedRoutes($httpMethod, $resourceUri, $reload = false)

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid unused parameters such as '$reload'.
Open

    public function getMatchedRoutes($httpMethod, $resourceUri, $reload = false)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

There are no issues that match your filters.

Category
Status