Sign upLogin

thestrukture/IDE

View on GitHub
Star
api/handlers/rest_ApiTerminal_realtime.go

Summary

Maintainability
A
2 hrs
Test Coverage
F
0%

Function ApiTerminal_realtime has 58 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ApiTerminal_realtime(w http.ResponseWriter, r *http.Request, session *sessions.Session) (response string, callmet bool) {

    c, err := globals.Upgrader.Upgrade(w, r, nil)
    if err != nil {
        log.Print("upgrade:", err)
Severity: Minor
Found in api/handlers/rest_ApiTerminal_realtime.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                    } else if isLinux {

                    ctx = exec.InteractiveExec(cm1)
                } else {
                    ctx = exec.InteractiveExec(cm1, cm2)
    Severity: Major
    Found in api/handlers/rest_ApiTerminal_realtime.go - About 45 mins to fix

      Function ApiTerminal_realtime has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Open

      func ApiTerminal_realtime(w http.ResponseWriter, r *http.Request, session *sessions.Session) (response string, callmet bool) {

    c, err := globals.Upgrader.Upgrade(w, r, nil)
    if err != nil {
        log.Print("upgrade:", err)
      Severity: Minor
      Found in api/handlers/rest_ApiTerminal_realtime.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      comment on exported function ApiTerminal_realtime should be of the form "ApiTerminal_realtime ..."
      Open

      //
      Severity: Minor
      Found in api/handlers/rest_ApiTerminal_realtime.go by golint

      don't use underscores in Go names; func ApiTerminal_realtime should be APITerminalRealtime
      Open

      func ApiTerminal_realtime(w http.ResponseWriter, r *http.Request, session *sessions.Session) (response string, callmet bool) {
      Severity: Minor
      Found in api/handlers/rest_ApiTerminal_realtime.go by golint

      package comment should be of the form "Package handlers ..."
      Open

      // File generated by Gopher Sauce
      Severity: Minor
      Found in api/handlers/rest_ApiTerminal_realtime.go by golint

      Your code does not pass gofmt in 1 place. Go fmt your code!
      Open

      // File generated by Gopher Sauce
      Severity: Minor
      Found in api/handlers/rest_ApiTerminal_realtime.go by gofmt

      There are no issues that match your filters.

      Category
      Status