Sign upLogin

thestrukture/IDE

View on GitHub
Star
api/handlers/rest_POSTApiDelete.go

Summary

Maintainability
D
1 day
Test Coverage
F
14%

Function POSTApiDelete has a Cognitive Complexity of 70 (exceeds 20 allowed). Consider refactoring.
Open

func POSTApiDelete(w http.ResponseWriter, r *http.Request, session *sessions.Session) (response string, callmet bool) {

    if r.FormValue("type") == "0" {

        //type pkg id
Severity: Minor
Found in api/handlers/rest_POSTApiDelete.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function POSTApiDelete has 130 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func POSTApiDelete(w http.ResponseWriter, r *http.Request, session *sessions.Session) (response string, callmet bool) {

    if r.FormValue("type") == "0" {

        //type pkg id
Severity: Major
Found in api/handlers/rest_POSTApiDelete.go - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                if v != r.FormValue("id") {
                temp = append(temp, v)
            }
    Severity: Major
    Found in api/handlers/rest_POSTApiDelete.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

          } else if r.FormValue("type") == "3" {
        //pkg
        if r.FormValue("conf") != "do" {
            response = templates.Delete(types.DForm{Text: "Are you sure you want to delete the package " + r.FormValue("pkg"), Link: "type=3&pkg=" + r.FormValue("pkg")})
      Severity: Major
      Found in api/handlers/rest_POSTApiDelete.go - About 45 mins to fix

        comment on exported function POSTApiDelete should be of the form "POSTApiDelete ..."
        Open

        //
        Severity: Minor
        Found in api/handlers/rest_POSTApiDelete.go by golint

        package comment should be of the form "Package handlers ..."
        Open

        // File generated by Gopher Sauce
        Severity: Minor
        Found in api/handlers/rest_POSTApiDelete.go by golint

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        // File generated by Gopher Sauce
        Severity: Minor
        Found in api/handlers/rest_POSTApiDelete.go by gofmt

        There are no issues that match your filters.

        Category
        Status