Sign upLogin

thetrung/plenty-sdk

View on GitHub
Star

Showing 12 of 12 total issues

Function swap_tokens has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const swap_tokens = async (
    toolkit,
    address_dex, 
    address_token_in, 
    address_token_out,
Severity: Major
Found in index.js - About 4 hrs to fix

    Function swap_tokens has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

    export const swap_tokens = async (
    toolkit,
    address_dex, 
    address_token_in, 
    address_token_out,
    Severity: Minor
    Found in index.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File index.js has 265 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { BigNumber } from 'bignumber.js'
import * as tezallet  from 'tezallet'

let IS_DEBUG = false
    Severity: Minor
    Found in index.js - About 2 hrs to fix

      Function get_supply has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const get_supply = async (dex, token_in, token_out) => {
    if (dex) {
        // log 
        if(IS_DEBUG) console.log(`found DEX: [${dex.address}],dex`)
        const dex_contract = dex.address
      Severity: Major
      Found in index.js - About 2 hrs to fix

        Function swap_by_amount has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const swap_by_amount = async (toolkit, 
    token_in, token_out, 
    amount_token_in, 
    is_estimation = true,
    slippage = 0.005) => {
        Severity: Minor
        Found in index.js - About 1 hr to fix

          Function get_supply has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          export const get_supply = async (dex, token_in, token_out) => {
    if (dex) {
        // log 
        if(IS_DEBUG) console.log(`found DEX: [${dex.address}],dex`)
        const dex_contract = dex.address
          Severity: Minor
          Found in index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                        case dex.token1.symbol:
                    token_out_decimals = dex.token1.decimals
                    token_in_decimals = dex.token2.decimals
                    token_out_supply = token1_pool
                    token_in_supply = token2_pool
          Severity: Major
          Found in index.js and 1 other location - About 1 hr to fix
          index.js on lines 100..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          case dex.token2.symbol:
                    token_out_decimals = dex.token2.decimals
                    token_in_decimals = dex.token1.decimals
                    token_out_supply = token2_pool
                    token_in_supply = token1_pool
          Severity: Major
          Found in index.js and 1 other location - About 1 hr to fix
          index.js on lines 107..112

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if(!dex){
        const message = {success: false, error: `can't find DEX for ${token_in}/${token_out}`}
        console.error(message)
        return message
    }
          Severity: Major
          Found in index.js and 1 other location - About 1 hr to fix
          index.js on lines 348..352

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if(!supply){
        const message = {success: false, error: `can't find supply for ${token_in}/${token_out}`}
        console.error(message)
        return message
    }
          Severity: Major
          Found in index.js and 1 other location - About 1 hr to fix
          index.js on lines 340..344

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                      return { 
                success: true, 
                hash: op.hash,
                max_fees: max_fees
            }
          Severity: Major
          Found in index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return undefined
            Severity: Major
            Found in index.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language