Sign upLogin

thi-ng/umbrella

View on GitHub
Star
packages/shader-ast-stdlib/src/noise/hash.ts

Summary

Maintainability
D
3 days
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

export const hash22 = defn(V2, "hash22", [V2], (p) => {
    let x: Vec3Sym;
    return [
        (x = sym(fract(mul($(p, "xyx"), H)))),
        addSelf(x, dot(x, add($(x, "yzx"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 164..171
packages/shader-ast-stdlib/src/noise/hash.ts on lines 212..219
packages/shader-ast-stdlib/src/noise/hash.ts on lines 228..235

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

export const hash42 = defn(V4, "hash42", [V2], (p) => {
    let x: Vec4Sym;
    return [
        (x = sym(fract(mul($(p, "xyxy"), H4)))),
        addSelf(x, dot(x, add($(x, "wzxy"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 116..123
packages/shader-ast-stdlib/src/noise/hash.ts on lines 164..171
packages/shader-ast-stdlib/src/noise/hash.ts on lines 228..235

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

export const hash32 = defn(V3, "hash32", [V2], (p) => {
    let x: Vec3Sym;
    return [
        (x = sym(fract(mul($(p, "xyx"), H)))),
        addSelf(x, dot(x, add($(x, "yzx"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 116..123
packages/shader-ast-stdlib/src/noise/hash.ts on lines 212..219
packages/shader-ast-stdlib/src/noise/hash.ts on lines 228..235

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Invalid

export const hash43 = defn(V4, "hash43", [V3], (p) => {
    let x: Vec4Sym;
    return [
        (x = sym(fract(mul($(p, "xyzx"), H4)))),
        addSelf(x, dot(x, add($(x, "wzxy"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 116..123
packages/shader-ast-stdlib/src/noise/hash.ts on lines 164..171
packages/shader-ast-stdlib/src/noise/hash.ts on lines 212..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const hash12 = defn(F, "hash12", [V2], (p) => {
    let x: Vec3Sym;
    return [
        (x = sym(fract(mul($(p, "xyx"), 0.1031)))),
        addSelf(x, dot(x, add($(x, "yzx"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 1 other location - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 84..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const hash13 = defn(F, "hash13", [V3], (p) => {
    let x: Vec3Sym;
    return [
        (x = sym(fract(mul($(p, "xyx"), 0.1031)))),
        addSelf(x, dot(x, add($(x, "yzx"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 1 other location - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 68..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const hash41 = defn(V4, "hash41", [F], (p) => {
    let x: Vec4Sym;
    return [
        (x = sym(fract(mul(p, H4)))),
        addSelf(x, dot(x, add($(x, "wzxy"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 132..139
packages/shader-ast-stdlib/src/noise/hash.ts on lines 148..155
packages/shader-ast-stdlib/src/noise/hash.ts on lines 180..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const hash33 = defn(V3, "hash33", [V3], (p) => {
    let x: Vec3Sym;
    return [
        (x = sym(fract(mul(p, H)))),
        addSelf(x, dot(x, add($(x, "yzx"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 132..139
packages/shader-ast-stdlib/src/noise/hash.ts on lines 148..155
packages/shader-ast-stdlib/src/noise/hash.ts on lines 196..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const hash23 = defn(V2, "hash23", [V3], (p) => {
    let x: Vec3Sym;
    return [
        (x = sym(fract(mul(p, H)))),
        addSelf(x, dot(x, add($(x, "yzx"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 148..155
packages/shader-ast-stdlib/src/noise/hash.ts on lines 180..187
packages/shader-ast-stdlib/src/noise/hash.ts on lines 196..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const hash31 = defn(V3, "hash31", [F], (p) => {
    let x: Vec3Sym;
    return [
        (x = sym(fract(mul(p, H)))),
        addSelf(x, dot(x, add($(x, "yzx"), 19.19))),
Severity: Major
Found in packages/shader-ast-stdlib/src/noise/hash.ts and 3 other locations - About 4 hrs to fix
packages/shader-ast-stdlib/src/noise/hash.ts on lines 132..139
packages/shader-ast-stdlib/src/noise/hash.ts on lines 180..187
packages/shader-ast-stdlib/src/noise/hash.ts on lines 196..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status