Sign upLogin

thiagopradi/octopus

View on GitHub
Star

Showing 237 of 237 total issues

Method legacy_method_missing_logic has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def legacy_method_missing_logic(method, *args, &block)
      if should_clean_connection_proxy?(method)
        conn = select_connection
        clean_connection_proxy
        conn.send(method, *args, &block)
Severity: Minor
Found in lib/octopus/proxy.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return [targetNode];
Severity: Major
Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return true;
    Severity: Major
    Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return value;
      Severity: Major
      Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                      if (Element.descendantOf(targetNode, node)) return [targetNode];
        Severity: Major
        Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return (targetNode && Element.descendantOf(targetNode, root)) ? [targetNode] : [];
          Severity: Major
          Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                if (!responder) return element;
            Severity: Major
            Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return element;
              Severity: Major
              Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    if (!responders) return;
                Severity: Major
                Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return [];
                  Severity: Major
                  Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                              if (node == targetNode) return [targetNode];
                    Severity: Major
                    Found in sample_app/public/javascripts/prototype.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if(Element.getStyle(this.update, 'display')!='none') this.options.onHide(this.element, this.update);
                      Severity: Minor
                      Found in sample_app/public/javascripts/controls.js and 1 other location - About 30 mins to fix
                      sample_app/public/javascripts/controls.js on lines 95..95

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 45.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if(Element.getStyle(this.update, 'display')=='none') this.options.onShow(this.element, this.update);
                      Severity: Minor
                      Found in sample_app/public/javascripts/controls.js and 1 other location - About 30 mins to fix
                      sample_app/public/javascripts/controls.js on lines 117..117

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 45.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function createForm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        createForm: function() {
    var ipe = this;
    function addText(mode, condition) {
      var text = ipe.options['text' + mode + 'Controls'];
      if (!text || condition === false) return;
                      Severity: Minor
                      Found in sample_app/public/javascripts/controls.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        add: function(element) {
    element = $(element);
    var options = Object.extend({
      greedy:     true,
      hoverclass: null,
                      Severity: Minor
                      Found in sample_app/public/javascripts/dragdrop.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function collectTextNodesIgnoreClass has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      Element.collectTextNodesIgnoreClass = function(element, className) {
  return $A($(element).childNodes).collect( function(node) {
    return (node.nodeType==3 ? node.nodeValue :
      ((node.hasChildNodes() && !Element.hasClassName(node,className)) ?
        Element.collectTextNodesIgnoreClass(node, className) : ''));
                      Severity: Minor
                      Found in sample_app/public/javascripts/effects.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getInputs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        getInputs: function(form, typeName, name) {
    form = $(form);
    var inputs = form.getElementsByTagName('input');

    if (!typeName && !name) return $A(inputs).map(Element.extend);
                      Severity: Minor
                      Found in sample_app/public/javascripts/prototype.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function clonePosition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        clonePosition: function(element, source) {
    var options = Object.extend({
      setLeft:    true,
      setTop:     true,
      setWidth:   true,
                      Severity: Minor
                      Found in sample_app/public/javascripts/prototype.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getOffsetParent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        getOffsetParent: function(element) {
    if (element.offsetParent) return $(element.offsetParent);
    if (element == document.body) return $(element);

    while ((element = element.parentNode) && element != document.body)
                      Severity: Minor
                      Found in sample_app/public/javascripts/prototype.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        initialize: function(element) {
    this.element = $(element);
    if (!this.element) throw(Effect._elementDoesNotExistError);
    var options = Object.extend({
      style: { }
                      Severity: Minor
                      Found in sample_app/public/javascripts/effects.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language