Sign upLogin

thinkoner/thinkgo

View on GitHub
Star

Showing 16 of 16 total issues

RedisStore has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

type RedisStore struct {
    pool   *redis.Pool // redis connection pool
    tagSet *TagSet
    prefix string
}
Severity: Minor
Found in cache/redis_store.go - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (s *MemoryStore) Decrement(key string, value ...int) (int, error) {
    s.mu.RLock()
    defer s.mu.RUnlock()

    var by = 1
    Severity: Major
    Found in cache/memory_store.go and 1 other location - About 2 hrs to fix
    cache/memory_store.go on lines 89..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 221.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (s *MemoryStore) Increment(key string, value ...int) (int, error) {
    s.mu.RLock()
    defer s.mu.RUnlock()

    var by = 1
    Severity: Major
    Found in cache/memory_store.go and 1 other location - About 2 hrs to fix
    cache/memory_store.go on lines 113..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 221.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Route has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type Route struct {
    inited bool

    method      []string
    prefix      string
    Severity: Minor
    Found in router/route.go - About 2 hrs to fix

      Request has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type Request struct {
    Request       *http.Request
    method        string
    path          string
    query         map[string]string
      Severity: Minor
      Found in context/request.go - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (s *RedisStore) Increment(key string, value ...int) (int, error) {
    err := s.pushStandardKeys(key)
    if err != nil {
        return 0, err
    }
        Severity: Major
        Found in cache/redis_store.go and 1 other location - About 1 hr to fix
        cache/redis_store.go on lines 80..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (s *RedisStore) Decrement(key string, value ...int) (int, error) {
    err := s.pushStandardKeys(key)
    if err != nil {
        return 0, err
    }
        Severity: Major
        Found in cache/redis_store.go and 1 other location - About 1 hr to fix
        cache/redis_store.go on lines 62..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method Cookie.Set has 54 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (c *Cookie) Set(name interface{}, params ...interface{}) (*http.Cookie, error) {
    var cookie *http.Cookie

    switch name.(type) {
    case *http.Cookie:
        Severity: Minor
        Found in context/cookie.go - About 1 hr to fix

          Method Cookie.Set has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
          Open

          func (c *Cookie) Set(name interface{}, params ...interface{}) (*http.Cookie, error) {
    var cookie *http.Cookie

    switch name.(type) {
    case *http.Cookie:
          Severity: Minor
          Found in context/cookie.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method Cookie.Set has 7 return statements (exceeds 4 allowed).
          Open

          func (c *Cookie) Set(name interface{}, params ...interface{}) (*http.Cookie, error) {
    var cookie *http.Cookie

    switch name.(type) {
    case *http.Cookie:
          Severity: Major
          Found in context/cookie.go - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Request) Post(key string, value ...string) (string, error) {
    if v, ok := r.post[key]; ok {
        return v, nil
    }
            Severity: Minor
            Found in context/request.go and 1 other location - About 35 mins to fix
            context/request.go on lines 57..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Request) Query(key string, value ...string) (string, error) {
    if v, ok := r.query[key]; ok {
        return v, nil
    }
    if len(value) > 0 {
            Severity: Minor
            Found in context/request.go and 1 other location - About 35 mins to fix
            context/request.go on lines 84..93

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method RedisStore.Flush has 5 return statements (exceeds 4 allowed).
            Open

            func (s *RedisStore) Flush() error {
    if s.tagSet != nil {
        err := s.deleteForeverKeys()
        if err != nil {
            return err
            Severity: Major
            Found in cache/redis_store.go - About 35 mins to fix

              Method RedisStore.deleteKeysByReference has 5 return statements (exceeds 4 allowed).
              Open

              func (s *RedisStore) deleteKeysByReference(reference string) error {
    if s.tagSet == nil {
        return nil
    }
              Severity: Major
              Found in cache/redis_store.go - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (h *ConsoleHandler) Handle(r record.Record) bool {
    if !h.IsHandling(r) {
        return false
    }
                Severity: Minor
                Found in log/handler/console.go and 1 other location - About 35 mins to fix
                log/handler/file.go on lines 45..55

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (h *FileHandler) Handle(r record.Record) bool {
    if !h.IsHandling(r) {
        return false
    }
                Severity: Minor
                Found in log/handler/file.go and 1 other location - About 35 mins to fix
                log/handler/console.go on lines 52..62

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language