Sign upLogin

thooams/ui_bibz

View on GitHub
Star
app/assets/javascripts/forms/formula.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function go has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  go(ch) {
    let i;
    const me = this;
    let flag = 0;
    for (i in me.rg2) {
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(){
    this.res = ""

    this.t = {
      x: "*",
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Function go has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  go(ch) {
    let i;
    const me = this;
    let flag = 0;
    for (i in me.rg2) {
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

    if (((par1 != null) && (par2 != null) && (par1.length !== par2.length)) || ((par1 == null) && (par2 != null)) || ((par1 != null) && (par2 == null))) {
      return me.res = "Unclosed parenthesis.";
    } else if (/.*[\+x\*\/\-]$/.test(q)) {
      return me.res = "Formula ending with an operator.";
    } else {
Severity: Major
Found in app/assets/javascripts/forms/formula.js - About 1 hr to fix

Function suite has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  suite(q) {
    const me   = this;
    const par1 = q.match(/\(/g);
    const par2 = q.match(/\)/g);
    if (((par1 != null) && (par2 != null) && (par1.length !== par2.length)) || ((par1 == null) && (par2 != null)) || ((par1 != null) && (par2 == null))) {
Severity: Minor
Found in app/assets/javascripts/forms/formula.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status